From 6df3877fc962c2bb3d0438633dfd24a185af6838 Mon Sep 17 00:00:00 2001

From: Paul Mackerras <paulus@ozlabs.org>

Date: Tue, 13 Feb 2018 15:45:21 +1100

Subject: [PATCH] KVM: PPC: Book3S: Fix compile error that occurs with some gcc

 versions

References: bsc#1061840

Patch-mainline: v4.16-rc5

Git-commit: 6df3877fc962c2bb3d0438633dfd24a185af6838

Some versions of gcc generate a warning that the variable "emulated"

may be used uninitialized in function kvmppc_handle_load128_by2x64().

It would be used uninitialized if kvmppc_handle_load128_by2x64 was

ever called with vcpu->arch.mmio_vmx_copy_nums == 0, but neither of

the callers ever do that, so there is no actual bug.  When gcc

generates a warning, it causes the build to fail because arch/powerpc

is compiled with -Werror.

This silences the warning by initializing "emulated" to EMULATE_DONE.

Fixes: 09f984961c13 ("KVM: PPC: Book3S: Add MMIO emulation for VMX instructions")

Reported-by: Michael Ellerman <mpe@ellerman.id.au>

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>

Acked-by: Michal Suchanek <msuchanek@suse.de>

---

 arch/powerpc/kvm/powerpc.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c

index 0083142c2f84..52c205373986 100644

--- a/arch/powerpc/kvm/powerpc.c

+++ b/arch/powerpc/kvm/powerpc.c

@@ -1345,7 +1345,7 @@ static int kvmppc_emulate_mmio_vsx_loadstore(struct kvm_vcpu *vcpu,

 int kvmppc_handle_load128_by2x64(struct kvm_run *run, struct kvm_vcpu *vcpu,

 		unsigned int rt, int is_default_endian)

 {

-	enum emulation_result emulated;

+	enum emulation_result emulated = EMULATE_DONE;

 	while (vcpu->arch.mmio_vmx_copy_nums) {

 		emulated = __kvmppc_handle_load(run, vcpu, rt, 8,

-- 

2.13.7