|
Joerg Roedel |
d89aa8 |
From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
|
|
Joerg Roedel |
d89aa8 |
Date: Wed, 27 Jun 2018 10:31:21 -0500
|
|
Joerg Roedel |
d89aa8 |
Subject: iommu/amd: Add support for higher 64-bit IOMMU Control Register
|
|
Joerg Roedel |
d89aa8 |
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git
|
|
Joerg Roedel |
d89aa8 |
Git-commit: e881dbd5d4a6950c9e2e7623c79d9578949365c9
|
|
Joerg Roedel |
d89aa8 |
Patch-mainline: queued, upstream in v4.19-rc1
|
|
Joerg Roedel |
d89aa8 |
References: fate#324429
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
Currently, the driver only supports lower 32-bit of IOMMU Control register.
|
|
Joerg Roedel |
d89aa8 |
However, newer AMD IOMMU specification has extended this register
|
|
Joerg Roedel |
d89aa8 |
to 64-bit. Therefore, replace the accessing API with the 64-bit version.
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
Cc: Joerg Roedel <jroedel@suse.de>
|
|
Joerg Roedel |
d89aa8 |
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
|
|
Joerg Roedel |
d89aa8 |
Signed-off-by: Joerg Roedel <jroedel@suse.de>
|
|
Joerg Roedel |
d89aa8 |
---
|
|
Joerg Roedel |
d89aa8 |
drivers/iommu/amd_iommu_init.c | 26 +++++++++++++-------------
|
|
Joerg Roedel |
d89aa8 |
1 file changed, 13 insertions(+), 13 deletions(-)
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
|
|
Joerg Roedel |
d89aa8 |
index 904c575d1677..7d494f2c28a1 100644
|
|
Joerg Roedel |
d89aa8 |
--- a/drivers/iommu/amd_iommu_init.c
|
|
Joerg Roedel |
d89aa8 |
+++ b/drivers/iommu/amd_iommu_init.c
|
|
Joerg Roedel |
d89aa8 |
@@ -280,9 +280,9 @@ static void clear_translation_pre_enabled(struct amd_iommu *iommu)
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
static void init_translation_status(struct amd_iommu *iommu)
|
|
Joerg Roedel |
d89aa8 |
{
|
|
Joerg Roedel |
d89aa8 |
- u32 ctrl;
|
|
Joerg Roedel |
d89aa8 |
+ u64 ctrl;
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
- ctrl = readl(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ ctrl = readq(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
if (ctrl & (1<
|
|
Joerg Roedel |
d89aa8 |
iommu->flags |= AMD_IOMMU_FLAG_TRANS_PRE_ENABLED;
|
|
Joerg Roedel |
d89aa8 |
}
|
|
Joerg Roedel |
d89aa8 |
@@ -386,30 +386,30 @@ static void iommu_set_device_table(struct amd_iommu *iommu)
|
|
Joerg Roedel |
d89aa8 |
/* Generic functions to enable/disable certain features of the IOMMU. */
|
|
Joerg Roedel |
d89aa8 |
static void iommu_feature_enable(struct amd_iommu *iommu, u8 bit)
|
|
Joerg Roedel |
d89aa8 |
{
|
|
Joerg Roedel |
d89aa8 |
- u32 ctrl;
|
|
Joerg Roedel |
d89aa8 |
+ u64 ctrl;
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
- ctrl = readl(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
- ctrl |= (1 << bit);
|
|
Joerg Roedel |
d89aa8 |
- writel(ctrl, iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ ctrl = readq(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ ctrl |= (1ULL << bit);
|
|
Joerg Roedel |
d89aa8 |
+ writeq(ctrl, iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
}
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
static void iommu_feature_disable(struct amd_iommu *iommu, u8 bit)
|
|
Joerg Roedel |
d89aa8 |
{
|
|
Joerg Roedel |
d89aa8 |
- u32 ctrl;
|
|
Joerg Roedel |
d89aa8 |
+ u64 ctrl;
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
- ctrl = readl(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
- ctrl &= ~(1 << bit);
|
|
Joerg Roedel |
d89aa8 |
- writel(ctrl, iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ ctrl = readq(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ ctrl &= ~(1ULL << bit);
|
|
Joerg Roedel |
d89aa8 |
+ writeq(ctrl, iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
}
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
static void iommu_set_inv_tlb_timeout(struct amd_iommu *iommu, int timeout)
|
|
Joerg Roedel |
d89aa8 |
{
|
|
Joerg Roedel |
d89aa8 |
- u32 ctrl;
|
|
Joerg Roedel |
d89aa8 |
+ u64 ctrl;
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
- ctrl = readl(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ ctrl = readq(iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
ctrl &= ~CTRL_INV_TO_MASK;
|
|
Joerg Roedel |
d89aa8 |
ctrl |= (timeout << CONTROL_INV_TIMEOUT) & CTRL_INV_TO_MASK;
|
|
Joerg Roedel |
d89aa8 |
- writel(ctrl, iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
+ writeq(ctrl, iommu->mmio_base + MMIO_CONTROL_OFFSET);
|
|
Joerg Roedel |
d89aa8 |
}
|
|
Joerg Roedel |
d89aa8 |
|
|
Joerg Roedel |
d89aa8 |
/* Function to enable the hardware */
|
|
Joerg Roedel |
d89aa8 |
|