From: Baoquan He <bhe@redhat.com>

Date: Wed, 9 Aug 2017 16:33:35 +0800

Subject: Revert "iommu/amd: Suppress IO_PAGE_FAULTs in kdump kernel"

Patch-mainline: v4.14-rc1

Git-commit: 9494ea90a56d013f4257686c8daf49203cd900c0

References: bsc#1043261

This reverts commit 54bd63570484167cb13edf81e31fff107b879981.

We still need the IO_PAGE_FAULT message to warn error after the

issue of on-flight dma in kdump kernel is fixed.

Signed-off-by: Baoquan He <bhe@redhat.com>

Signed-off-by: Joerg Roedel <jroedel@suse.de>

---

 drivers/iommu/amd_iommu.c       | 3 +--

 drivers/iommu/amd_iommu_init.c  | 9 ---------

 drivers/iommu/amd_iommu_types.h | 1 -

 3 files changed, 1 insertion(+), 12 deletions(-)

--- a/drivers/iommu/amd_iommu.c

+++ b/drivers/iommu/amd_iommu.c

@@ -2086,8 +2086,7 @@ static void set_dte_entry(u16 devid, str

 		flags    |= tmp;

 	}

-

-	flags &= ~(DTE_FLAG_SA | 0xffffULL);

+	flags &= ~(0xffffUL);

 	flags |= domain->id;

 	amd_iommu_dev_table[devid].data[1]  = flags;

--- a/drivers/iommu/amd_iommu_init.c

+++ b/drivers/iommu/amd_iommu_init.c

@@ -30,7 +30,6 @@

 #include <linux/iommu.h>

 #include <linux/kmemleak.h>

 #include <linux/mem_encrypt.h>

-#include <linux/crash_dump.h>

 #include <asm/pci-direct.h>

 #include <asm/iommu.h>

 #include <asm/gart.h>

@@ -1943,14 +1942,6 @@ static void init_device_table_dma(void)

 	for (devid = 0; devid <= amd_iommu_last_bdf; ++devid) {

 		set_dev_entry_bit(devid, DEV_ENTRY_VALID);

 		set_dev_entry_bit(devid, DEV_ENTRY_TRANSLATION);

-		/*

-		 * In kdump kernels in-flight DMA from the old kernel might

-		 * cause IO_PAGE_FAULTs. There are no reports that a kdump

-		 * actually failed because of that, so just disable fault

-		 * reporting in the hardware to get rid of the messages

-		 */

-		if (is_kdump_kernel())

-			set_dev_entry_bit(devid, DEV_ENTRY_NO_PAGE_FAULT);

 	}

 }

--- a/drivers/iommu/amd_iommu_types.h

+++ b/drivers/iommu/amd_iommu_types.h

@@ -322,7 +322,6 @@

 #define IOMMU_PTE_IW (1ULL << 62)

 #define DTE_FLAG_IOTLB	(1ULL << 32)

-#define DTE_FLAG_SA	(1ULL << 34)

 #define DTE_FLAG_GV	(1ULL << 55)

 #define DTE_FLAG_MASK	(0x3ffULL << 32)

 #define DTE_GLX_SHIFT	(56)