From 184b39e6bb5de0b90c4eade83f11ec3bb3baec9a Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>

Date: Thu, 6 Jul 2017 16:58:33 -0500

Subject: [PATCH 62/86] drm/rockchip: fix NULL check on devm_kzalloc() return

 value

Git-commit: 6f6e0b217a93011f8e11b9a2d5521a08fcf36990

Patch-mainline: v4.13-rc1

References: fate#323912

The right variable to check here is port, not dp.

This issue was detected using Coccinelle and the following semantic patch:

@@

expression x;

identifier fld;

@@

* x = devm_kzalloc(...);

  ... when != x == NULL

  x->fld

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Acked-by: Mark Yao <mark.yao@rock-chips.com>

Signed-off-by: Sean Paul <seanpaul@chromium.org>

Link: http://patchwork.freedesktop.org/patch/msgid/20170706215833.GA25411@embeddedgus

Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>

---

 drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c

index 14fa1f8351e8..9b0b0588bbed 100644

--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c

+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c

@@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)

 			continue;

 		port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);

-		if (!dp)

+		if (!port)

 			return -ENOMEM;

 		port->extcon = extcon;

-- 

2.11.0