From: Mark Bloch <markb@mellanox.com>

Date: Mon, 11 Feb 2019 17:40:54 +0200

Subject: RDMA/mlx5: Fix memory leak in case we fail to add an IB device

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Patch-mainline: v5.1-rc1

Git-commit: fc9e4477f924e84d7798f7a1d41401d699de1219

References: bsc#1103991 FATE#326007

Make sure the IB device is freed on failure.

Fixes: b5ca15ad7e61 ("IB/mlx5: Add proper representors support")

Signed-off-by: Mark Bloch <markb@mellanox.com>

Reviewed-by: Bodong Wang <bodong@mellanox.com>

Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

---

 drivers/infiniband/hw/mlx5/ib_rep.c |    4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/infiniband/hw/mlx5/ib_rep.c

+++ b/drivers/infiniband/hw/mlx5/ib_rep.c

@@ -66,8 +66,10 @@ mlx5_ib_vport_rep_load(struct mlx5_core_

 	ibdev->mdev = dev;

 	ibdev->num_ports = max(MLX5_CAP_GEN(dev, num_ports),

 			       MLX5_CAP_GEN(dev, num_vhca_ports));

-	if (!__mlx5_ib_add(ibdev, &rep_profile))

+	if (!__mlx5_ib_add(ibdev, &rep_profile)) {

+		ib_dealloc_device(&ibdev->ib_dev);

 		return -EINVAL;

+	}

 	rep->rep_if[REP_IB].priv = ibdev;