From: Carolyn Wyborny <carolyn.wyborny@intel.com>

Date: Fri, 14 Jul 2017 09:10:07 -0400

Subject: i40e: Fix for unused value issue found by static analysis

Patch-mainline: v4.14-rc1

Git-commit: 19279235bea221798e3307a8bec2c02559cab0c5

References: bsc#1056658 FATE#322188 bsc#1056662 FATE#322186

This patch fixes an issue where an error return value is

set, but without an immediate exit, the value can be overwritten

by the following code execution.  The condition  at this point

is not fatal, so remove the error assignment and comment the

intent for future code maintainers

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Acked-by: Benjamin Poirier <bpoirier@suse.com>

---

 drivers/net/ethernet/intel/i40e/i40e_main.c |    4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/ethernet/intel/i40e/i40e_main.c

+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c

@@ -9884,13 +9884,15 @@ static int i40e_add_vsi(struct i40e_vsi

 			 */

 			ret = i40e_vsi_config_tc(vsi, enabled_tc);

 			if (ret) {

+				/* Single TC condition is not fatal,

+				 * message and continue

+				 */

 				dev_info(&pf->pdev->dev,

 					 "failed to configure TCs for main VSI tc_map 0x%08x, err %s aq_err %s\n",

 					 enabled_tc,

 					 i40e_stat_str(&pf->hw, ret),

 					 i40e_aq_str(&pf->hw,

 						    pf->hw.aq.asq_last_status));

-				ret = -ENOENT;

 			}

 		}

 		break;