Thomas Bogendoerfer 7f94d1
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Thomas Bogendoerfer 7f94d1
Date: Mon, 15 Jan 2018 11:47:53 -0800
Thomas Bogendoerfer 7f94d1
Subject: nfp: use the correct index for link speed table
Thomas Bogendoerfer 7f94d1
Patch-mainline: v4.15-rc9
Thomas Bogendoerfer 7f94d1
Git-commit: 0d9c9f0f40ca262b67fc06a702b85f3976f5e1a1
Thomas Bogendoerfer 7f94d1
References: bsc#1055968
Thomas Bogendoerfer 7f94d1
Thomas Bogendoerfer 7f94d1
sts variable is holding link speed as well as state.  We should
Thomas Bogendoerfer 7f94d1
be using ls to index into ls_to_ethtool.
Thomas Bogendoerfer 7f94d1
Thomas Bogendoerfer 7f94d1
Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
Thomas Bogendoerfer 7f94d1
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thomas Bogendoerfer 7f94d1
Signed-off-by: David S. Miller <davem@davemloft.net>
Thomas Bogendoerfer 7f94d1
Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Thomas Bogendoerfer 7f94d1
---
Thomas Bogendoerfer 7f94d1
 drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c |    2 +-
Thomas Bogendoerfer 7f94d1
 1 file changed, 1 insertion(+), 1 deletion(-)
Thomas Bogendoerfer 7f94d1
Thomas Bogendoerfer 7f94d1
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
Thomas Bogendoerfer 7f94d1
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
Thomas Bogendoerfer 7f94d1
@@ -306,7 +306,7 @@ nfp_net_get_link_ksettings(struct net_de
Thomas Bogendoerfer 7f94d1
 	    ls >= ARRAY_SIZE(ls_to_ethtool))
Thomas Bogendoerfer 7f94d1
 		return 0;
Thomas Bogendoerfer 7f94d1
 
Thomas Bogendoerfer 7f94d1
-	cmd->base.speed = ls_to_ethtool[sts];
Thomas Bogendoerfer 7f94d1
+	cmd->base.speed = ls_to_ethtool[ls];
Thomas Bogendoerfer 7f94d1
 	cmd->base.duplex = DUPLEX_FULL;
Thomas Bogendoerfer 7f94d1
 
Thomas Bogendoerfer 7f94d1
 	return 0;