Hannes Reinecke fb1713
From: James Smart <jsmart2021@gmail.com>
Hannes Reinecke fb1713
Date: Fri, 11 May 2018 17:50:24 -0700
Hannes Reinecke fb1713
Subject: [PATCH] nvme-fc: remove setting DNR on exception conditions
Hannes Reinecke fb1713
References: bsc#1098706
Hannes Reinecke fb1713
Git-commit: 90fcaf5d54c57037e9f879f17b58497db7156c3e
Hannes Reinecke fb1713
Patch-mainline: v4.18-rc1
Hannes Reinecke fb1713
Hannes Reinecke fb1713
Current code will set DNR if the controller is deleting or there is
Hannes Reinecke fb1713
an error during controller init. None of this is necessary.
Hannes Reinecke fb1713
Hannes Reinecke fb1713
Remove the code that sets DNR
Hannes Reinecke fb1713
Hannes Reinecke fb1713
Signed-off-by: James Smart <james.smart@broadcom.com>
Hannes Reinecke fb1713
Reviewed-by: Hannes Reinecke <hare@suse.com>
Hannes Reinecke fb1713
Signed-off-by: Christoph Hellwig <hch@lst.de>
Hannes Reinecke fb1713
Signed-off-by: Hannes Reinecke <hare@suse.de>
Hannes Reinecke fb1713
---
Hannes Reinecke fb1713
 drivers/nvme/host/fc.c | 10 ----------
Hannes Reinecke fb1713
 1 file changed, 10 deletions(-)
Hannes Reinecke fb1713
Hannes Reinecke fb1713
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
Hannes Reinecke fb1713
index 3f7be5067bfd..f57b9871b802 100644
Hannes Reinecke fb1713
--- a/drivers/nvme/host/fc.c
Hannes Reinecke fb1713
+++ b/drivers/nvme/host/fc.c
Hannes Reinecke fb1713
@@ -1690,16 +1690,6 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req)
Hannes Reinecke fb1713
 		goto check_error;
Hannes Reinecke fb1713
 	}
Hannes Reinecke fb1713
 
Hannes Reinecke fb1713
-	/*
Hannes Reinecke fb1713
-	 * Force failures of commands if we're killing the controller
Hannes Reinecke fb1713
-	 * or have an error on a command used to create an new association
Hannes Reinecke fb1713
-	 */
Hannes Reinecke fb1713
-	if (status &&
Hannes Reinecke fb1713
-	    (blk_queue_dying(rq->q) ||
Hannes Reinecke fb1713
-	     ctrl->ctrl.state == NVME_CTRL_NEW ||
Hannes Reinecke fb1713
-	     ctrl->ctrl.state == NVME_CTRL_CONNECTING))
Hannes Reinecke fb1713
-		status |= cpu_to_le16(NVME_SC_DNR << 1);
Hannes Reinecke fb1713
-
Hannes Reinecke fb1713
 	__nvme_fc_fcpop_chk_teardowns(ctrl, op, opstate);
Hannes Reinecke fb1713
 	nvme_end_request(rq, status, result);
Hannes Reinecke fb1713
 
Hannes Reinecke fb1713
-- 
Hannes Reinecke fb1713
2.12.3
Hannes Reinecke fb1713