Oliver Neukum d53571
From 084a804e01205bcd74cd0849bc72cb5c88f8e648 Mon Sep 17 00:00:00 2001
Oliver Neukum d53571
From: Roger Quadros <rogerq@ti.com>
Oliver Neukum d53571
Date: Tue, 27 Feb 2018 12:41:41 +0200
Oliver Neukum d53571
Subject: [PATCH] usb: dwc3: Fix lock-up on ID change during system
Oliver Neukum d53571
 suspend/resume
Oliver Neukum d53571
Git-commit: 084a804e01205bcd74cd0849bc72cb5c88f8e648
Benjamin Poirier 2528c7
Patch-mainline: v4.16-rc6
Oliver Neukum d53571
References: bsc#1087092
Oliver Neukum d53571
Oliver Neukum d53571
To reproduce the lock up do the following
Oliver Neukum d53571
- connect otg host adapter and a USB device to the dual-role port
Oliver Neukum d53571
so that it is in host mode.
Oliver Neukum d53571
- suspend to mem.
Oliver Neukum d53571
- disconnect otg adapter.
Oliver Neukum d53571
- resume the system.
Oliver Neukum d53571
Oliver Neukum d53571
If we call dwc3_host_exit() before tasks are thawed
Oliver Neukum d53571
xhci_plat_remove() seems to lock up at the second usb_remove_hcd() call.
Oliver Neukum d53571
Oliver Neukum d53571
To work around this we queue the _dwc3_set_mode() work on
Oliver Neukum d53571
the system_freezable_wq.
Oliver Neukum d53571
Oliver Neukum d53571
Fixes: 41ce1456e1db ("usb: dwc3: core: make dwc3_set_mode() work properly")
Oliver Neukum d53571
Cc: <stable@vger.kernel.org> # v4.12+
Oliver Neukum d53571
Suggested-by: Manu Gautam <mgautam@codeaurora.org>
Oliver Neukum d53571
Signed-off-by: Roger Quadros <rogerq@ti.com>
Oliver Neukum d53571
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Oliver Neukum d53571
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Oliver Neukum d53571
---
Oliver Neukum d53571
 drivers/usb/dwc3/core.c | 2 +-
Oliver Neukum d53571
 1 file changed, 1 insertion(+), 1 deletion(-)
Oliver Neukum d53571
Oliver Neukum d53571
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
Oliver Neukum d53571
index f1d838a4acd6..e94bf91cc58a 100644
Oliver Neukum d53571
--- a/drivers/usb/dwc3/core.c
Oliver Neukum d53571
+++ b/drivers/usb/dwc3/core.c
Oliver Neukum d53571
@@ -175,7 +175,7 @@ void dwc3_set_mode(struct dwc3 *dwc, u32 mode)
Oliver Neukum d53571
 	dwc->desired_dr_role = mode;
Oliver Neukum d53571
 	spin_unlock_irqrestore(&dwc->lock, flags);
Oliver Neukum d53571
 
Oliver Neukum d53571
-	queue_work(system_power_efficient_wq, &dwc->drd_work);
Oliver Neukum d53571
+	queue_work(system_freezable_wq, &dwc->drd_work);
Oliver Neukum d53571
 }
Oliver Neukum d53571
 
Oliver Neukum d53571
 u32 dwc3_core_fifo_space(struct dwc3_ep *dep, u8 type)
Oliver Neukum d53571
-- 
Oliver Neukum d53571
2.13.6
Oliver Neukum d53571