Michal Kubecek c1e272
From: Cong Wang <xiyou.wangcong@gmail.com>
Michal Kubecek c1e272
Date: Wed, 31 Jan 2018 15:02:47 -0800
Michal Kubecek c1e272
Subject: netfilter: xt_cgroup: initialize info->priv in cgroup_mt_check_v1()
Michal Kubecek c1e272
Patch-mainline: v4.16-rc1
Michal Kubecek c1e272
Git-commit: ba7cd5d95f25cc6005f687dabdb4e7a6063adda9
Michal Kubecek c1e272
References: bsc#1076830
Michal Kubecek c1e272
Michal Kubecek c1e272
xt_cgroup_info_v1->priv is an internal pointer only used for kernel,
Michal Kubecek c1e272
we should not trust what user-space provides.
Michal Kubecek c1e272
Michal Kubecek c1e272
Reported-by: <syzbot+4fbcfcc0d2e6592bd641@syzkaller.appspotmail.com>
Michal Kubecek c1e272
Fixes: c38c4597e4bf ("netfilter: implement xt_cgroup cgroup2 path match")
Michal Kubecek c1e272
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Michal Kubecek c1e272
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Michal Kubecek c1e272
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Michal Kubecek c1e272
Acked-by: Michal Kubecek <mkubecek@suse.cz>
Michal Kubecek c1e272
Michal Kubecek c1e272
---
Michal Kubecek c1e272
 net/netfilter/xt_cgroup.c | 1 +
Michal Kubecek c1e272
 1 file changed, 1 insertion(+)
Michal Kubecek c1e272
Michal Kubecek c1e272
diff --git a/net/netfilter/xt_cgroup.c b/net/netfilter/xt_cgroup.c
Michal Kubecek c1e272
index 1db1ce59079f..891f4e7e8ea7 100644
Michal Kubecek c1e272
--- a/net/netfilter/xt_cgroup.c
Michal Kubecek c1e272
+++ b/net/netfilter/xt_cgroup.c
Michal Kubecek c1e272
@@ -52,6 +52,7 @@ static int cgroup_mt_check_v1(const struct xt_mtchk_param *par)
Michal Kubecek c1e272
 		return -EINVAL;
Michal Kubecek c1e272
 	}
Michal Kubecek c1e272
 
Michal Kubecek c1e272
+	info->priv = NULL;
Michal Kubecek c1e272
 	if (info->has_path) {
Michal Kubecek c1e272
 		cgrp = cgroup_get_from_path(info->path);
Michal Kubecek c1e272
 		if (IS_ERR(cgrp)) {
Michal Kubecek c1e272
-- 
Michal Kubecek c1e272
2.16.2
Michal Kubecek c1e272