Joerg Roedel f7a89a
From: Nicholas Mc Guire <hofrat@osadl.org>
Joerg Roedel f7a89a
Date: Fri, 29 Jun 2018 13:50:10 -0500
Joerg Roedel f7a89a
Subject: PCI: xilinx-nwl: Add missing of_node_put()
Joerg Roedel f7a89a
Git-commit: 342639d996f18bc0a4db2f42a84230c0a966dc94
Joerg Roedel f7a89a
Patch-mainline: v4.18-rc4
Joerg Roedel f7a89a
References: bsc#1109806
Joerg Roedel f7a89a
Joerg Roedel f7a89a
The call to of_get_next_child() returns a node pointer with
Joerg Roedel f7a89a
refcount incremented thus it must be explicitly decremented
Joerg Roedel f7a89a
here after the last usage.
Joerg Roedel f7a89a
Joerg Roedel f7a89a
Fixes: ab597d35ef11 ("PCI: xilinx-nwl: Add support for Xilinx NWL PCIe Host Controller")
Joerg Roedel f7a89a
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Joerg Roedel f7a89a
[lorenzo.pieralisi@arm.com: updated commit log]
Joerg Roedel f7a89a
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Joerg Roedel f7a89a
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Joerg Roedel f7a89a
Acked-by: Joerg Roedel <jroedel@suse.de>
Joerg Roedel f7a89a
---
Joerg Roedel f7a89a
 drivers/pci/controller/pcie-xilinx-nwl.c | 2 +-
Joerg Roedel f7a89a
 1 file changed, 1 insertion(+), 1 deletion(-)
Joerg Roedel f7a89a
Joerg Roedel f7a89a
--- a/drivers/pci/host/pcie-xilinx-nwl.c
Joerg Roedel f7a89a
+++ b/drivers/pci/host/pcie-xilinx-nwl.c
Joerg Roedel f7a89a
@@ -520,7 +520,7 @@ static int nwl_pcie_init_irq_domain(stru
Joerg Roedel f7a89a
 							INTX_NUM,
Joerg Roedel f7a89a
 							&legacy_domain_ops,
Joerg Roedel f7a89a
 							pcie);
Joerg Roedel f7a89a
-
Joerg Roedel f7a89a
+	of_node_put(legacy_intc_node);
Joerg Roedel f7a89a
 	if (!pcie->legacy_irq_domain) {
Joerg Roedel f7a89a
 		dev_err(dev, "failed to create IRQ domain\n");
Joerg Roedel f7a89a
 		return -ENOMEM;