Jiri Slaby 5ba6cd
From: Sasha Finkelstein <fnkl.kernel@gmail.com>
Jiri Slaby 5ba6cd
Date: Fri, 10 Mar 2023 11:28:42 +0100
Jiri Slaby 5ba6cd
Subject: [PATCH] bluetooth: btbcm: Fix logic error in forming the board name.
Jiri Slaby 5ba6cd
References: bsc#1012628
Jiri Slaby 5ba6cd
Patch-mainline: 6.2.12
Jiri Slaby 5ba6cd
Git-commit: b76abe4648c1acc791a207e7c08d1719eb9f4ea8
Jiri Slaby 5ba6cd
Jiri Slaby 5ba6cd
commit b76abe4648c1acc791a207e7c08d1719eb9f4ea8 upstream.
Jiri Slaby 5ba6cd
Jiri Slaby 5ba6cd
This patch fixes an incorrect loop exit condition in code that replaces
Jiri Slaby 5ba6cd
'/' symbols in the board name. There might also be a memory corruption
Jiri Slaby 5ba6cd
issue here, but it is unlikely to be a real problem.
Jiri Slaby 5ba6cd
Jiri Slaby 5ba6cd
Cc: <stable@vger.kernel.org>
Jiri Slaby 5ba6cd
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Jiri Slaby 5ba6cd
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Jiri Slaby 5ba6cd
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jiri Slaby 5ba6cd
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri Slaby 5ba6cd
---
Jiri Slaby 5ba6cd
 drivers/bluetooth/btbcm.c | 2 +-
Jiri Slaby 5ba6cd
 1 file changed, 1 insertion(+), 1 deletion(-)
Jiri Slaby 5ba6cd
Jiri Slaby 5ba6cd
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
Jiri Slaby 5ba6cd
index 3006e2a0..43e98a59 100644
Jiri Slaby 5ba6cd
--- a/drivers/bluetooth/btbcm.c
Jiri Slaby 5ba6cd
+++ b/drivers/bluetooth/btbcm.c
Jiri Slaby 5ba6cd
@@ -511,7 +511,7 @@ static const char *btbcm_get_board_name(struct device *dev)
Jiri Slaby 5ba6cd
 	len = strlen(tmp) + 1;
Jiri Slaby 5ba6cd
 	board_type = devm_kzalloc(dev, len, GFP_KERNEL);
Jiri Slaby 5ba6cd
 	strscpy(board_type, tmp, len);
Jiri Slaby 5ba6cd
-	for (i = 0; i < board_type[i]; i++) {
Jiri Slaby 5ba6cd
+	for (i = 0; i < len; i++) {
Jiri Slaby 5ba6cd
 		if (board_type[i] == '/')
Jiri Slaby 5ba6cd
 			board_type[i] = '-';
Jiri Slaby 5ba6cd
 	}
Jiri Slaby 5ba6cd
-- 
Jiri Slaby 5ba6cd
2.35.3
Jiri Slaby 5ba6cd