Jiri Slaby 79f3de
From: Yicong Yang <yangyicong@hisilicon.com>
Jiri Slaby 79f3de
Date: Mon, 13 Mar 2023 15:45:51 +0800
Jiri Slaby 79f3de
Subject: [PATCH] i2c: hisi: Avoid redundant interrupts
Jiri Slaby 79f3de
References: bsc#1012628
Jiri Slaby 79f3de
Patch-mainline: 6.2.12
Jiri Slaby 79f3de
Git-commit: cc9812a3096d1986caca9a23bee99effc45c08df
Jiri Slaby 79f3de
Jiri Slaby 79f3de
[ Upstream commit cc9812a3096d1986caca9a23bee99effc45c08df ]
Jiri Slaby 79f3de
Jiri Slaby 79f3de
After issuing all the messages we can disable the TX_EMPTY interrupts
Jiri Slaby 79f3de
to avoid handling redundant interrupts. For doing a sinlge bus
Jiri Slaby 79f3de
detection (i2cdetect -y -r 0) we can reduce ~97% interrupts (before
Jiri Slaby 79f3de
~12000 after ~400).
Jiri Slaby 79f3de
Jiri Slaby 79f3de
Signed-off-by: Sheng Feng <fengsheng5@huawei.com>
Jiri Slaby 79f3de
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Jiri Slaby 79f3de
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Jiri Slaby 79f3de
Signed-off-by: Sasha Levin <sashal@kernel.org>
Jiri Slaby 79f3de
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri Slaby 79f3de
---
Jiri Slaby 79f3de
 drivers/i2c/busses/i2c-hisi.c | 7 +++++++
Jiri Slaby 79f3de
 1 file changed, 7 insertions(+)
Jiri Slaby 79f3de
Jiri Slaby 79f3de
diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c
Jiri Slaby 79f3de
index f5c37d2f..e067671b 100644
Jiri Slaby 79f3de
--- a/drivers/i2c/busses/i2c-hisi.c
Jiri Slaby 79f3de
+++ b/drivers/i2c/busses/i2c-hisi.c
Jiri Slaby 79f3de
@@ -316,6 +316,13 @@ static void hisi_i2c_xfer_msg(struct hisi_i2c_controller *ctlr)
Jiri Slaby 79f3de
 		    max_write == 0)
Jiri Slaby 79f3de
 			break;
Jiri Slaby 79f3de
 	}
Jiri Slaby 79f3de
+
Jiri Slaby 79f3de
+	/*
Jiri Slaby 79f3de
+	 * Disable the TX_EMPTY interrupt after finishing all the messages to
Jiri Slaby 79f3de
+	 * avoid overwhelming the CPU.
Jiri Slaby 79f3de
+	 */
Jiri Slaby 79f3de
+	if (ctlr->msg_tx_idx == ctlr->msg_num)
Jiri Slaby 79f3de
+		hisi_i2c_disable_int(ctlr, HISI_I2C_INT_TX_EMPTY);
Jiri Slaby 79f3de
 }
Jiri Slaby 79f3de
 
Jiri Slaby 79f3de
 static irqreturn_t hisi_i2c_irq(int irq, void *context)
Jiri Slaby 79f3de
-- 
Jiri Slaby 79f3de
2.35.3
Jiri Slaby 79f3de