From: Reinette Chatre <reinette.chatre@intel.com>

Date: Wed, 29 Mar 2023 13:13:11 -0700

Subject: [PATCH] PCI/MSI: Provide missing stub for pci_msix_can_alloc_dyn()

References: bsc#1012628

Patch-mainline: 6.2.12

Git-commit: 195d8e5da3acb17c5357526494f818a21e97cd10

commit 195d8e5da3acb17c5357526494f818a21e97cd10 upstream.

pci_msix_can_alloc_dyn() is not declared when CONFIG_PCI_MSI is disabled.

There is no existing user of pci_msix_can_alloc_dyn() but work is in

progress to change this. This work encounters the following error when

CONFIG_PCI_MSI is disabled:

  drivers/vfio/pci/vfio_pci_intrs.c:427:21: error: implicit declaration of function 'pci_msix_can_alloc_dyn' [-Werror=implicit-function-declaration]

Provide definition for pci_msix_can_alloc_dyn() in preparation for users

that need to compile when CONFIG_PCI_MSI is disabled.

[bhelgaas: Also reported by Arnd Bergmann <arnd@kernel.org> in

drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c; added his Fixes: line]

Fixes: fb0a6a268dcd ("net/mlx5: Provide external API for allocating vectors")

Fixes: 34026364df8e ("PCI/MSI: Provide post-enable dynamic allocation interfaces for MSI-X")

Link: https://lore.kernel.org/oe-kbuild-all/202303291000.PWFqGCxH-lkp@intel.com/

Link: https://lore.kernel.org/r/310ecc4815dae4174031062f525245f0755c70e2.1680119924.git.reinette.chatre@intel.com

Reported-by: kernel test robot <lkp@intel.com>

Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Cc: stable@vger.kernel.org	# v6.2+

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 include/linux/pci.h | 2 ++

 1 file changed, 2 insertions(+)

diff --git a/include/linux/pci.h b/include/linux/pci.h

index db6ec828..7e8e8633 100644

--- a/include/linux/pci.h

+++ b/include/linux/pci.h

@@ -1623,6 +1623,8 @@ pci_alloc_irq_vectors(struct pci_dev *dev, unsigned int min_vecs,

 					      flags, NULL);

 }

+static inline bool pci_msix_can_alloc_dyn(struct pci_dev *dev)

+{ return false; }

 static inline struct msi_map pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index,

 						   const struct irq_affinity_desc *affdesc)

 {

-- 

2.35.3