Jiri Slaby 1376fa
From: Sascha Hauer <s.hauer@pengutronix.de>
Jiri Slaby 1376fa
Date: Fri, 10 Feb 2023 12:16:32 +0100
Jiri Slaby 1376fa
Subject: [PATCH] wifi: rtw88: usb: drop now unnecessary URB size check
Jiri Slaby 1376fa
References: bsc#1012628
Jiri Slaby 1376fa
Patch-mainline: 6.2.2
Jiri Slaby 1376fa
Git-commit: 462c8db6a01160836c68e262d25566f2447148d9
Jiri Slaby 1376fa
Jiri Slaby 1376fa
commit 462c8db6a01160836c68e262d25566f2447148d9 upstream.
Jiri Slaby 1376fa
Jiri Slaby 1376fa
Now that we send URBs with the URB_ZERO_PACKET flag set we no longer
Jiri Slaby 1376fa
need to make sure that the URB sizes are not multiple of the
Jiri Slaby 1376fa
bulkout_size. Drop the check.
Jiri Slaby 1376fa
Jiri Slaby 1376fa
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Jiri Slaby 1376fa
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Jiri Slaby 1376fa
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Jiri Slaby 1376fa
Link: https://lore.kernel.org/r/20230210111632.1985205-4-s.hauer@pengutronix.de
Jiri Slaby 1376fa
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jiri Slaby 1376fa
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri Slaby 1376fa
---
Jiri Slaby 1376fa
 drivers/net/wireless/realtek/rtw88/usb.c | 15 +--------------
Jiri Slaby 1376fa
 1 file changed, 1 insertion(+), 14 deletions(-)
Jiri Slaby 1376fa
Jiri Slaby 1376fa
diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
Jiri Slaby 1376fa
index 1a09c928..2a8336b1 100644
Jiri Slaby 1376fa
--- a/drivers/net/wireless/realtek/rtw88/usb.c
Jiri Slaby 1376fa
+++ b/drivers/net/wireless/realtek/rtw88/usb.c
Jiri Slaby 1376fa
@@ -414,24 +414,11 @@ static int rtw_usb_write_data_rsvd_page(struct rtw_dev *rtwdev, u8 *buf,
Jiri Slaby 1376fa
 					u32 size)
Jiri Slaby 1376fa
 {
Jiri Slaby 1376fa
 	const struct rtw_chip_info *chip = rtwdev->chip;
Jiri Slaby 1376fa
-	struct rtw_usb *rtwusb;
Jiri Slaby 1376fa
 	struct rtw_tx_pkt_info pkt_info = {0};
Jiri Slaby 1376fa
-	u32 len, desclen;
Jiri Slaby 1376fa
-
Jiri Slaby 1376fa
-	rtwusb = rtw_get_usb_priv(rtwdev);
Jiri Slaby 1376fa
 
Jiri Slaby 1376fa
 	pkt_info.tx_pkt_size = size;
Jiri Slaby 1376fa
 	pkt_info.qsel = TX_DESC_QSEL_BEACON;
Jiri Slaby 1376fa
-
Jiri Slaby 1376fa
-	desclen = chip->tx_pkt_desc_sz;
Jiri Slaby 1376fa
-	len = desclen + size;
Jiri Slaby 1376fa
-	if (len % rtwusb->bulkout_size == 0) {
Jiri Slaby 1376fa
-		len += RTW_USB_PACKET_OFFSET_SZ;
Jiri Slaby 1376fa
-		pkt_info.offset = desclen + RTW_USB_PACKET_OFFSET_SZ;
Jiri Slaby 1376fa
-		pkt_info.pkt_offset = 1;
Jiri Slaby 1376fa
-	} else {
Jiri Slaby 1376fa
-		pkt_info.offset = desclen;
Jiri Slaby 1376fa
-	}
Jiri Slaby 1376fa
+	pkt_info.offset = chip->tx_pkt_desc_sz;
Jiri Slaby 1376fa
 
Jiri Slaby 1376fa
 	return rtw_usb_write_data(rtwdev, &pkt_info, buf);
Jiri Slaby 1376fa
 }
Jiri Slaby 1376fa
-- 
Jiri Slaby 1376fa
2.35.3
Jiri Slaby 1376fa