Jiri Slaby ef7db2
From: Magnus Karlsson <magnus.karlsson@intel.com>
Jiri Slaby ef7db2
Date: Wed, 11 Jan 2023 10:35:12 +0100
Jiri Slaby ef7db2
Subject: [PATCH] selftests/xsk: print correct payload for packet dump
Jiri Slaby ef7db2
References: bsc#1012628
Jiri Slaby ef7db2
Patch-mainline: 6.2.3
Jiri Slaby ef7db2
Git-commit: 2d0b2ae2871ae6d42a9f0a4280e0fb5bff8d38b8
Jiri Slaby ef7db2
Jiri Slaby ef7db2
[ Upstream commit 2d0b2ae2871ae6d42a9f0a4280e0fb5bff8d38b8 ]
Jiri Slaby ef7db2
Jiri Slaby ef7db2
Print the correct payload when the packet dump option is selected. The
Jiri Slaby ef7db2
network to host conversion was forgotten and the payload was
Jiri Slaby ef7db2
erronously declared to be an int instead of an unsigned int.
Jiri Slaby ef7db2
Jiri Slaby ef7db2
Fixes: facb7cb2e909 ("selftests/bpf: Xsk selftests - SKB POLL, NOPOLL")
Jiri Slaby ef7db2
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Jiri Slaby ef7db2
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Jiri Slaby ef7db2
Link: https://lore.kernel.org/r/20230111093526.11682-2-magnus.karlsson@gmail.com
Jiri Slaby ef7db2
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Jiri Slaby ef7db2
Signed-off-by: Sasha Levin <sashal@kernel.org>
Jiri Slaby ef7db2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri Slaby ef7db2
---
Jiri Slaby ef7db2
 tools/testing/selftests/bpf/xskxceiver.c | 4 ++--
Jiri Slaby ef7db2
 1 file changed, 2 insertions(+), 2 deletions(-)
Jiri Slaby ef7db2
Jiri Slaby ef7db2
diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
Jiri Slaby ef7db2
index 162d3a51..2ff43b22 100644
Jiri Slaby ef7db2
--- a/tools/testing/selftests/bpf/xskxceiver.c
Jiri Slaby ef7db2
+++ b/tools/testing/selftests/bpf/xskxceiver.c
Jiri Slaby ef7db2
@@ -767,7 +767,7 @@ static void pkt_dump(void *pkt, u32 len)
Jiri Slaby ef7db2
 	struct ethhdr *ethhdr;
Jiri Slaby ef7db2
 	struct udphdr *udphdr;
Jiri Slaby ef7db2
 	struct iphdr *iphdr;
Jiri Slaby ef7db2
-	int payload, i;
Jiri Slaby ef7db2
+	u32 payload, i;
Jiri Slaby ef7db2
 
Jiri Slaby ef7db2
 	ethhdr = pkt;
Jiri Slaby ef7db2
 	iphdr = pkt + sizeof(*ethhdr);
Jiri Slaby ef7db2
@@ -792,7 +792,7 @@ static void pkt_dump(void *pkt, u32 len)
Jiri Slaby ef7db2
 	fprintf(stdout, "DEBUG>> L4: udp_hdr->src: %d\n", ntohs(udphdr->source));
Jiri Slaby ef7db2
 	fprintf(stdout, "DEBUG>> L4: udp_hdr->dst: %d\n", ntohs(udphdr->dest));
Jiri Slaby ef7db2
 	/*extract L5 frame */
Jiri Slaby ef7db2
-	payload = *((uint32_t *)(pkt + PKT_HDR_SIZE));
Jiri Slaby ef7db2
+	payload = ntohl(*((u32 *)(pkt + PKT_HDR_SIZE)));
Jiri Slaby ef7db2
 
Jiri Slaby ef7db2
 	fprintf(stdout, "DEBUG>> L5: payload: %d\n", payload);
Jiri Slaby ef7db2
 	fprintf(stdout, "---------------------------------------\n");
Jiri Slaby ef7db2
-- 
Jiri Slaby ef7db2
2.35.3
Jiri Slaby ef7db2