From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Date: Sat, 14 Jan 2023 18:33:09 +0100

Subject: [PATCH] x86/signal: Fix the value returned by strict_sas_size()

References: bsc#1012628

Patch-mainline: 6.2.3

Git-commit: ef6dfc4b238a435ab552207ec09e4a82b6426d31

[ Upstream commit ef6dfc4b238a435ab552207ec09e4a82b6426d31 ]

Functions used with __setup() return 1 when the argument has been

successfully parsed.

Reverse the returned value so that 1 is returned when kstrtobool() is

successful (i.e. returns 0).

My understanding of these __setup() functions is that returning 1 or 0

does not change much anyway - so this is more of a cleanup than a

functional fix.

I spot it and found it spurious while looking at something else.

Even if the output is not perfect, you'll get the idea with:

   $ git grep -B2 -A10 retu.*kstrtobool | grep __setup -B10

Fixes: 3aac3ebea08f ("x86/signal: Implement sigaltstack size validation")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Signed-off-by: Ingo Molnar <mingo@kernel.org>

Link: https://lore.kernel.org/r/73882d43ebe420c9d8fb82d0560021722b243000.1673717552.git.christophe.jaillet@wanadoo.fr

Signed-off-by: Sasha Levin <sashal@kernel.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 arch/x86/kernel/signal.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c

index 1504eb8d..004cb30b 100644

--- a/arch/x86/kernel/signal.c

+++ b/arch/x86/kernel/signal.c

@@ -360,7 +360,7 @@ static bool strict_sigaltstack_size __ro_after_init = false;

 static int __init strict_sas_size(char *arg)

 {

-	return kstrtobool(arg, &strict_sigaltstack_size);

+	return kstrtobool(arg, &strict_sigaltstack_size) == 0;

 }

 __setup("strict_sas_size", strict_sas_size);

-- 

2.35.3