From: Dan Carpenter <error27@gmail.com>

Date: Tue, 14 Feb 2023 18:43:38 +0300

Subject: [PATCH] iw_cxgb4: Fix potential NULL dereference in

 c4iw_fill_res_cm_id_entry()

References: bsc#1012628

Patch-mainline: 6.2.3

Git-commit: 4ca446b127c568b59cb8d9748b6f70499624bb18

[ Upstream commit 4ca446b127c568b59cb8d9748b6f70499624bb18 ]

This condition needs to match the previous "if (epcp->state == LISTEN) {"

exactly to avoid a NULL dereference of either "listen_ep" or "ep". The

problem is that "epcp" has been re-assigned so just testing

"if (epcp->state == LISTEN) {" a second time is not sufficient.

Fixes: 116aeb887371 ("iw_cxgb4: provide detailed provider-specific CM_ID information")

Signed-off-by: Dan Carpenter <error27@gmail.com>

Link: https://lore.kernel.org/r/Y+usKuWIKr4dimZh@kili

Signed-off-by: Leon Romanovsky <leon@kernel.org>

Signed-off-by: Sasha Levin <sashal@kernel.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 drivers/infiniband/hw/cxgb4/restrack.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/restrack.c b/drivers/infiniband/hw/cxgb4/restrack.c

index ff645b95..fd22c85d 100644

--- a/drivers/infiniband/hw/cxgb4/restrack.c

+++ b/drivers/infiniband/hw/cxgb4/restrack.c

@@ -238,7 +238,7 @@ int c4iw_fill_res_cm_id_entry(struct sk_buff *msg,

 	if (rdma_nl_put_driver_u64_hex(msg, "history", epcp->history))

 		goto err_cancel_table;

-	if (epcp->state == LISTEN) {

+	if (listen_ep) {

 		if (rdma_nl_put_driver_u32(msg, "stid", listen_ep->stid))

 			goto err_cancel_table;

 		if (rdma_nl_put_driver_u32(msg, "backlog", listen_ep->backlog))

-- 

2.35.3