From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Date: Mon, 13 Feb 2023 11:57:09 +0800

Subject: [PATCH] phy: rockchip-typec: Fix unsigned comparison with less than

 zero

References: bsc#1012628

Patch-mainline: 6.2.5

Git-commit: f765c59c5a72546a2d74a92ae5d0eb0329d8e247

[ Upstream commit f765c59c5a72546a2d74a92ae5d0eb0329d8e247 ]

The dp and ufp are defined as bool type, the return value type of

function extcon_get_state should be int, so the type of dp and ufp

are modified to int.

./drivers/phy/rockchip/phy-rockchip-typec.c:827:12-14: WARNING: Unsigned expression compared with zero: dp > 0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3962

Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Link: https://lore.kernel.org/r/20230213035709.99027-1-jiapeng.chong@linux.alibaba.com

Signed-off-by: Vinod Koul <vkoul@kernel.org>

Signed-off-by: Sasha Levin <sashal@kernel.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 drivers/phy/rockchip/phy-rockchip-typec.c | 3 +--

 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c

index 6aea512e..39db8acd 100644

--- a/drivers/phy/rockchip/phy-rockchip-typec.c

+++ b/drivers/phy/rockchip/phy-rockchip-typec.c

@@ -808,9 +808,8 @@ static int tcphy_get_mode(struct rockchip_typec_phy *tcphy)

 	struct extcon_dev *edev = tcphy->extcon;

 	union extcon_property_value property;

 	unsigned int id;

-	bool ufp, dp;

 	u8 mode;

-	int ret;

+	int ret, ufp, dp;

 	if (!edev)

 		return MODE_DFP_USB;

-- 

2.35.3