From: Nathan Chancellor <nathan@kernel.org>

Date: Wed, 15 Feb 2023 10:12:12 -0700

Subject: [PATCH] macintosh: windfarm: Use unsigned type for 1-bit bitfields

References: bsc#1012628

Patch-mainline: 6.2.7

Git-commit: 748ea32d2dbd813d3bd958117bde5191182f909a

[ Upstream commit 748ea32d2dbd813d3bd958117bde5191182f909a ]

Clang warns:

  drivers/macintosh/windfarm_lm75_sensor.c:63:14: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]

                  lm->inited = 1;

                             ^ ~

  drivers/macintosh/windfarm_smu_sensors.c:356:19: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]

                  pow->fake_volts = 1;

                                  ^ ~

  drivers/macintosh/windfarm_smu_sensors.c:368:18: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]

                  pow->quadratic = 1;

                                 ^ ~

There is no bug here since no code checks the actual value of these

fields, just whether or not they are zero (boolean context), but this

can be easily fixed by switching to an unsigned type.

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Link: https://lore.kernel.org/r/20230215-windfarm-wsingle-bit-bitfield-constant-conversion-v1-1-26415072e855@kernel.org

Signed-off-by: Sasha Levin <sashal@kernel.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 drivers/macintosh/windfarm_lm75_sensor.c | 4 ++--

 drivers/macintosh/windfarm_smu_sensors.c | 4 ++--

 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/macintosh/windfarm_lm75_sensor.c b/drivers/macintosh/windfarm_lm75_sensor.c

index 24f0a444..9c6febce 100644

--- a/drivers/macintosh/windfarm_lm75_sensor.c

+++ b/drivers/macintosh/windfarm_lm75_sensor.c

@@ -33,8 +33,8 @@

 #endif

 struct wf_lm75_sensor {

-	int			ds1775 : 1;

-	int			inited : 1;

+	unsigned int		ds1775 : 1;

+	unsigned int		inited : 1;

 	struct i2c_client	*i2c;

 	struct wf_sensor	sens;

 };

diff --git a/drivers/macintosh/windfarm_smu_sensors.c b/drivers/macintosh/windfarm_smu_sensors.c

index 00c6fe25..2bdb73b3 100644

--- a/drivers/macintosh/windfarm_smu_sensors.c

+++ b/drivers/macintosh/windfarm_smu_sensors.c

@@ -274,8 +274,8 @@ struct smu_cpu_power_sensor {

 	struct list_head	link;

 	struct wf_sensor	*volts;

 	struct wf_sensor	*amps;

-	int			fake_volts : 1;

-	int			quadratic : 1;

+	unsigned int		fake_volts : 1;

+	unsigned int		quadratic : 1;

 	struct wf_sensor	sens;

 };

 #define to_smu_cpu_power(c) container_of(c, struct smu_cpu_power_sensor, sens)

-- 

2.35.3