From: Daniil Tatianin <d-tatianin@yandex-team.ru>

Date: Wed, 15 Mar 2023 22:46:18 +0300

Subject: [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour

References: bsc#1012628

Patch-mainline: 6.2.8

Git-commit: 470efd68a4653d9819d391489886432cd31bcd0b

[ Upstream commit 470efd68a4653d9819d391489886432cd31bcd0b ]

This fixes an issue where ->hour would erroneously get zeroed out

instead of ->min because of a bad copy paste.

Found by Linux Verification Center (linuxtesting.org) with the SVACE

static analysis tool.

Fixes: f240b6882211 ("qed: Add support for processing fcoe tlv request.")

Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>

Link: https://lore.kernel.org/r/20230315194618.579286-1-d-tatianin@yandex-team.ru

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Sasha Levin <sashal@kernel.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c

index 6190adf9..f55eed09 100644

--- a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c

+++ b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c

@@ -422,7 +422,7 @@ qed_mfw_get_tlv_time_value(struct qed_mfw_tlv_time *p_time,

 	if (p_time->hour > 23)

 		p_time->hour = 0;

 	if (p_time->min > 59)

-		p_time->hour = 0;

+		p_time->min = 0;

 	if (p_time->msec > 999)

 		p_time->msec = 0;

 	if (p_time->usec > 999)

-- 

2.35.3