From: Aurabindo Pillai <aurabindo.pillai@amd.com>

Date: Thu, 6 Apr 2023 15:48:48 -0400

Subject: [PATCH] drm/amd/display: Do not clear GPINT register when releasing

 DMUB from reset

References: bsc#1012628

Patch-mainline: 6.3.3

Git-commit: 99d92eaca5d915763b240aae24669f5bf3227ecf

[ Upstream commit 99d92eaca5d915763b240aae24669f5bf3227ecf ]

[Why & How]

There's no need to clear GPINT register for DMUB

when releasing it from reset. Fix that.

Fixes: ac2e555e0a7f ("drm/amd/display: Add DMCUB source files and changes for DCN32/321")

Reviewed-by: Leo Li <sunpeng.li@amd.com>

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>

Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Signed-off-by: Sasha Levin <sashal@kernel.org>

Signed-off-by: Jiri Slaby <jslaby@suse.cz>

---

 drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c | 1 -

 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c b/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c

index b0adbf78..9c20516b 100644

--- a/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c

+++ b/drivers/gpu/drm/amd/display/dmub/src/dmub_dcn32.c

@@ -137,7 +137,6 @@ void dmub_dcn32_reset(struct dmub_srv *dmub)

 void dmub_dcn32_reset_release(struct dmub_srv *dmub)

 {

-	REG_WRITE(DMCUB_GPINT_DATAIN1, 0);

 	REG_UPDATE(MMHUBBUB_SOFT_RESET, DMUIF_SOFT_RESET, 0);

 	REG_WRITE(DMCUB_SCRATCH15, dmub->psp_version & 0x001100FF);

 	REG_UPDATE_2(DMCUB_CNTL, DMCUB_ENABLE, 1, DMCUB_TRACEPORT_EN, 1);

-- 

2.35.3