Jiri Slaby cc46de
From: Hamza Mahfooz <hamza.mahfooz@amd.com>
Jiri Slaby cc46de
Date: Tue, 2 May 2023 11:59:08 -0400
Jiri Slaby cc46de
Subject: [PATCH] drm/amdgpu: fix an amdgpu_irq_put() issue in
Jiri Slaby cc46de
 gmc_v9_0_hw_fini()
Jiri Slaby cc46de
References: bsc#1012628
Jiri Slaby cc46de
Patch-mainline: 6.3.3
Jiri Slaby cc46de
Git-commit: 922a76ba31adf84e72bc947267385be420c689ee
Jiri Slaby cc46de
Jiri Slaby cc46de
commit 922a76ba31adf84e72bc947267385be420c689ee upstream.
Jiri Slaby cc46de
Jiri Slaby cc46de
As made mention of in commit 08c677cb0b43 ("drm/amdgpu: fix
Jiri Slaby cc46de
amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit 13af556104fa
Jiri Slaby cc46de
("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It
Jiri Slaby cc46de
is meaningless to call amdgpu_irq_put() for gmc.ecc_irq. So, remove it
Jiri Slaby cc46de
from gmc_v9_0_hw_fini().
Jiri Slaby cc46de
Jiri Slaby cc46de
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2522
Jiri Slaby cc46de
Fixes: 3029c855d79f ("drm/amdgpu: Fix desktop freezed after gpu-reset")
Jiri Slaby cc46de
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Jiri Slaby cc46de
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Jiri Slaby cc46de
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Jiri Slaby cc46de
Cc: stable@vger.kernel.org
Jiri Slaby cc46de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jiri Slaby cc46de
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Jiri Slaby cc46de
---
Jiri Slaby cc46de
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 -
Jiri Slaby cc46de
 1 file changed, 1 deletion(-)
Jiri Slaby cc46de
Jiri Slaby cc46de
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
Jiri Slaby cc46de
index b06170c0..83d22dd8 100644
Jiri Slaby cc46de
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
Jiri Slaby cc46de
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
Jiri Slaby cc46de
@@ -1987,7 +1987,6 @@ static int gmc_v9_0_hw_fini(void *handle)
Jiri Slaby cc46de
 	if (adev->mmhub.funcs->update_power_gating)
Jiri Slaby cc46de
 		adev->mmhub.funcs->update_power_gating(adev, false);
Jiri Slaby cc46de
 
Jiri Slaby cc46de
-	amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
Jiri Slaby cc46de
 	amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
Jiri Slaby cc46de
 
Jiri Slaby cc46de
 	return 0;
Jiri Slaby cc46de
-- 
Jiri Slaby cc46de
2.35.3
Jiri Slaby cc46de