Davidlohr Bueso cdb25c
From 69f0d429c413fe96db2c187475cebcc6e3a8c7f5 Mon Sep 17 00:00:00 2001
Davidlohr Bueso cdb25c
From: Alex Shi <alex.shi@linaro.org>
Davidlohr Bueso cdb25c
Date: Thu, 13 Jul 2017 14:18:24 +0800
Davidlohr Bueso cdb25c
Subject: [PATCH] locking/rtmutex: Remove unnecessary priority adjustment
Davidlohr Bueso cdb25c
Git-commit: 69f0d429c413fe96db2c187475cebcc6e3a8c7f5
Davidlohr Bueso cdb25c
Patch-mainline: v4.13-rc1
Davidlohr Bueso cdb25c
References: bsc#1050549
Davidlohr Bueso cdb25c
Davidlohr Bueso cdb25c
We don't need to adjust priority before adding a new pi_waiter, the
Davidlohr Bueso cdb25c
priority only needs to be updated after pi_waiter change or task
Davidlohr Bueso cdb25c
priority change.
Davidlohr Bueso cdb25c
Davidlohr Bueso cdb25c
Steven Rostedt pointed out:
Davidlohr Bueso cdb25c
Davidlohr Bueso cdb25c
  "Interesting, I did some git mining and this was added with the original
Davidlohr Bueso cdb25c
   entry of the rtmutex.c (23f78d4a03c5). Looking at even that version, I
Davidlohr Bueso cdb25c
   don't see the purpose of adjusting the task prio here. It is done
Davidlohr Bueso cdb25c
   before anything changes in the task."
Davidlohr Bueso cdb25c
Davidlohr Bueso cdb25c
Signed-off-by: Alex Shi <alex.shi@linaro.org>
Davidlohr Bueso cdb25c
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Davidlohr Bueso cdb25c
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Davidlohr Bueso cdb25c
Cc: Juri Lelli <juri.lelli@arm.com>
Davidlohr Bueso cdb25c
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Davidlohr Bueso cdb25c
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Davidlohr Bueso cdb25c
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Davidlohr Bueso cdb25c
Cc: Steven Rostedt <rostedt@goodmis.org>
Davidlohr Bueso cdb25c
Cc: Thomas Gleixner <tglx@linutronix.de>
Davidlohr Bueso cdb25c
Link: http://lkml.kernel.org/r/1499926704-28841-1-git-send-email-alex.shi@linaro.org
Davidlohr Bueso cdb25c
[ Enhance the changelog. ]
Davidlohr Bueso cdb25c
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Davidlohr Bueso cdb25c
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Davidlohr Bueso cdb25c
Davidlohr Bueso cdb25c
---
Davidlohr Bueso cdb25c
 kernel/locking/rtmutex.c | 1 -
Davidlohr Bueso cdb25c
 1 file changed, 1 deletion(-)
Davidlohr Bueso cdb25c
Davidlohr Bueso cdb25c
diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
Davidlohr Bueso cdb25c
index 78069895032a..649dc9d3951a 100644
Davidlohr Bueso cdb25c
--- a/kernel/locking/rtmutex.c
Davidlohr Bueso cdb25c
+++ b/kernel/locking/rtmutex.c
Davidlohr Bueso cdb25c
@@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
Davidlohr Bueso cdb25c
 		return -EDEADLK;
Davidlohr Bueso cdb25c
 
Davidlohr Bueso cdb25c
 	raw_spin_lock(&task->pi_lock);
Davidlohr Bueso cdb25c
-	rt_mutex_adjust_prio(task);
Davidlohr Bueso cdb25c
 	waiter->task = task;
Davidlohr Bueso cdb25c
 	waiter->lock = lock;
Davidlohr Bueso cdb25c
 	waiter->prio = task->prio;
Davidlohr Bueso cdb25c
-- 
Davidlohr Bueso cdb25c
2.12.0
Davidlohr Bueso cdb25c