From be0e97526455fefe3b7668b7fdf6cd247bf13318 Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <arnd@arndb.de>

Date: Mon, 26 Oct 2020 22:48:34 +0100

Subject: [PATCH] ACPI: dock: fix enum-conversion warning

Git-commit: be0e97526455fefe3b7668b7fdf6cd247bf13318

Patch-mainline: v5.10-rc2

References: git-fixes

gcc points out a type mismatch:

Drivers/acpi/dock.c: In function 'hot_remove_dock_devices':

drivers/acpi/dock.c:234:53: warning: implicit conversion from 'enum <anonymous>' to 'enum dock_callback_type' [-Wenum-conversion]

  234 |   dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, false);

This is harmless because 'false' still has the correct numeric value,

but passing DOCK_CALL_HANDLER documents better what is going on

and avoids the warning.

Fixes: 37f908778f20 ("ACPI / dock: Walk list in reverse order during removal of devices")

Fixes: f09ce741a03a ("ACPI / dock / PCI: Drop ACPI dock notifier chain")

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Hanjun Guo <guohanjun@huawei.com>

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/acpi/dock.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c

index 45d4b7b69de8..24e076f44d23 100644

--- a/drivers/acpi/dock.c

+++ b/drivers/acpi/dock.c

@@ -231,7 +231,8 @@ static void hot_remove_dock_devices(struct dock_station *ds)

 	 * between them).

 	 */

 	list_for_each_entry_reverse(dd, &ds->dependent_devices, list)

-		dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, false);

+		dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST,

+				   DOCK_CALL_HANDLER);

 	list_for_each_entry_reverse(dd, &ds->dependent_devices, list)

 		acpi_bus_trim(dd->adev);

-- 

2.16.4