From 3bbfd319034ddce59e023837a4aa11439460509b Mon Sep 17 00:00:00 2001

From: Feilong Lin <linfeilong@huawei.com>

Date: Thu, 25 Mar 2021 15:26:00 +0800

Subject: [PATCH] ACPI / hotplug / PCI: Fix reference count leak in enable_slot()

Git-commit: 3bbfd319034ddce59e023837a4aa11439460509b

Patch-mainline: v5.13-rc1

References: git-fixes

In enable_slot(), if pci_get_slot() returns NULL, we clear the SLOT_ENABLED

flag. When pci_get_slot() finds a device, it increments the device's

reference count.  In this case, we did not call pci_dev_put() to decrement

the reference count, so the memory of the device (struct pci_dev type) will

eventually leak.

Call pci_dev_put() to decrement its reference count when pci_get_slot()

returns a PCI device.

Link: https://lore.kernel.org/r/b411af88-5049-a1c6-83ac-d104a1f429be@huawei.com

Signed-off-by: Feilong Lin <linfeilong@huawei.com>

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/pci/hotplug/acpiphp_glue.c | 1 +

 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c

index 3365c93abf0e..f031302ad401 100644

--- a/drivers/pci/hotplug/acpiphp_glue.c

+++ b/drivers/pci/hotplug/acpiphp_glue.c

@@ -533,6 +533,7 @@ static void enable_slot(struct acpiphp_slot *slot, bool bridge)

 			slot->flags &= ~SLOT_ENABLED;

 			continue;

 		}

+		pci_dev_put(dev);

 	}

 }

-- 

2.26.2