From 475feec0c41ad71cb7d02f0310e56256606b57c5 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <tiwai@suse.de>

Date: Mon, 16 Dec 2019 16:12:24 +0100

Subject: [PATCH] ALSA: hda - Downgrade error message for single-cmd fallback

Git-commit: 475feec0c41ad71cb7d02f0310e56256606b57c5

Patch-mainline: v5.5-rc3

References: git-fixes

We made the error message for the CORB/RIRB communication clearer by

upgrading to dev_WARN() so that user can notice better.  But this

struck us like a boomerang: now it caught syzbot and reported back as

a fatal issue although it's not really any too serious bug that worth

for stopping the whole system.

OK, OK, let's be softy, downgrade it to the standard dev_err() again.

Fixes: dd65f7e19c69 ("ALSA: hda - Show the fatal CORB/RIRB error more clearly")

Reported-by: syzbot+b3028ac3933f5c466389@syzkaller.appspotmail.com

Link: https://lore.kernel.org/r/20191216151224.30013-1-tiwai@suse.de

Signed-off-by: Takashi Iwai <tiwai@suse.de>

---

 sound/pci/hda/hda_controller.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c

index 2f3b7a35f2d9..ba56b59b3e17 100644

--- a/sound/pci/hda/hda_controller.c

+++ b/sound/pci/hda/hda_controller.c

@@ -883,7 +883,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr,

 		return -EAGAIN; /* give a chance to retry */

 	}

-	dev_WARN(chip->card->dev,

+	dev_err(chip->card->dev,

 		"azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",

 		bus->last_cmd[addr]);

 	chip->single_cmd = 1;

-- 

2.16.4