From 833bc4cf9754643acc69b3c6b65988ca78df4460 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <dan.carpenter@oracle.com>

Date: Thu, 20 May 2021 08:08:24 +0300

Subject: [PATCH] ASoC: cs35l33: fix an error code in probe()

Git-commit: 833bc4cf9754643acc69b3c6b65988ca78df4460

Patch-mainline: v5.13-rc4

References: git-fixes

This error path returns zero (success) but it should return -EINVAL.

Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Link: https://lore.kernel.org/r/YKXuyGEzhPT35R3G@mwanda

Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 sound/soc/codecs/cs35l33.c | 1 +

 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c

index 7ad7b733af9b..e8f3dcfd144d 100644

--- a/sound/soc/codecs/cs35l33.c

+++ b/sound/soc/codecs/cs35l33.c

@@ -1201,6 +1201,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client,

 		dev_err(&i2c_client->dev,

 			"CS35L33 Device ID (%X). Expected ID %X\n",

 			devid, CS35L33_CHIP_ID);

+		ret = -EINVAL;

 		goto err_enable;

 	}

-- 

2.26.2