Takashi Iwai 996d49
From 7f103af4a10f375b9b346b4d0b730f6a66b8c451 Mon Sep 17 00:00:00 2001
Takashi Iwai 996d49
From: Charles Keepax <ckeepax@opensource.cirrus.com>
Takashi Iwai 996d49
Date: Thu, 23 Jun 2022 11:51:17 +0100
Takashi Iwai 996d49
Subject: [PATCH] ASoC: cs47l15: Fix event generation for low power mux control
Takashi Iwai 996d49
Git-commit: 7f103af4a10f375b9b346b4d0b730f6a66b8c451
Takashi Iwai 996d49
Patch-mainline: v5.19-rc6
Takashi Iwai 996d49
References: git-fixes
Takashi Iwai 996d49
Takashi Iwai 996d49
cs47l15_in1_adc_put always returns zero regardless of if the control
Takashi Iwai 996d49
value was updated. This results in missing notifications to user-space
Takashi Iwai 996d49
of the control change. Update the handling to return 1 when the value is
Takashi Iwai 996d49
changed.
Takashi Iwai 996d49
Takashi Iwai 996d49
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Takashi Iwai 996d49
Link: https://lore.kernel.org/r/20220623105120.1981154-3-ckeepax@opensource.cirrus.com
Takashi Iwai 996d49
Signed-off-by: Mark Brown <broonie@kernel.org>
Takashi Iwai 996d49
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 996d49
Takashi Iwai 996d49
---
Takashi Iwai 996d49
 sound/soc/codecs/cs47l15.c | 5 ++++-
Takashi Iwai 996d49
 1 file changed, 4 insertions(+), 1 deletion(-)
Takashi Iwai 996d49
Takashi Iwai 996d49
diff --git a/sound/soc/codecs/cs47l15.c b/sound/soc/codecs/cs47l15.c
Takashi Iwai 996d49
index 391fd7da331f..1c7d52bef893 100644
Takashi Iwai 996d49
--- a/sound/soc/codecs/cs47l15.c
Takashi Iwai 996d49
+++ b/sound/soc/codecs/cs47l15.c
Takashi Iwai 996d49
@@ -122,6 +122,9 @@ static int cs47l15_in1_adc_put(struct snd_kcontrol *kcontrol,
Takashi Iwai 996d49
 		snd_soc_kcontrol_component(kcontrol);
Takashi Iwai 996d49
 	struct cs47l15 *cs47l15 = snd_soc_component_get_drvdata(component);
Takashi Iwai 996d49
 
Takashi Iwai 996d49
+	if (!!ucontrol->value.integer.value[0] == cs47l15->in1_lp_mode)
Takashi Iwai 996d49
+		return 0;
Takashi Iwai 996d49
+
Takashi Iwai 996d49
 	switch (ucontrol->value.integer.value[0]) {
Takashi Iwai 996d49
 	case 0:
Takashi Iwai 996d49
 		/* Set IN1 to normal mode */
Takashi Iwai 996d49
@@ -150,7 +153,7 @@ static int cs47l15_in1_adc_put(struct snd_kcontrol *kcontrol,
Takashi Iwai 996d49
 		break;
Takashi Iwai 996d49
 	}
Takashi Iwai 996d49
 
Takashi Iwai 996d49
-	return 0;
Takashi Iwai 996d49
+	return 1;
Takashi Iwai 996d49
 }
Takashi Iwai 996d49
 
Takashi Iwai 996d49
 static const struct snd_kcontrol_new cs47l15_snd_controls[] = {
Takashi Iwai 996d49
-- 
Takashi Iwai 996d49
2.35.3
Takashi Iwai 996d49