|
Takashi Iwai |
b66ca0 |
From 5871321fb4558c55bf9567052b618ff0be6b975e Mon Sep 17 00:00:00 2001
|
|
Takashi Iwai |
b66ca0 |
From: Mark Brown <broonie@kernel.org>
|
|
Takashi Iwai |
b66ca0 |
Date: Sat, 4 Jun 2022 11:52:46 +0100
|
|
Takashi Iwai |
b66ca0 |
Subject: [PATCH] ASoC: ops: Fix off by one in range control validation
|
|
Takashi Iwai |
b66ca0 |
Git-commit: 5871321fb4558c55bf9567052b618ff0be6b975e
|
|
Takashi Iwai |
b66ca0 |
Patch-mainline: v5.19-rc6
|
|
Takashi Iwai |
b66ca0 |
References: git-fixes
|
|
Takashi Iwai |
b66ca0 |
|
|
Takashi Iwai |
b66ca0 |
We currently report that range controls accept a range of 0..(max-min) but
|
|
Takashi Iwai |
b66ca0 |
accept writes in the range 0..(max-min+1). Remove that extra +1.
|
|
Takashi Iwai |
b66ca0 |
|
|
Takashi Iwai |
b66ca0 |
Signed-off-by: Mark Brown <broonie@kernel.org>
|
|
Takashi Iwai |
b66ca0 |
Link: https://lore.kernel.org/r/20220604105246.4055214-1-broonie@kernel.org
|
|
Takashi Iwai |
b66ca0 |
Acked-by: Takashi Iwai <tiwai@suse.de>
|
|
Takashi Iwai |
b66ca0 |
|
|
Takashi Iwai |
b66ca0 |
---
|
|
Takashi Iwai |
b66ca0 |
sound/soc/soc-ops.c | 4 ++--
|
|
Takashi Iwai |
b66ca0 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
Takashi Iwai |
b66ca0 |
|
|
Takashi Iwai |
b66ca0 |
diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c
|
|
Takashi Iwai |
b66ca0 |
index e693070f51fe..d867f449d82d 100644
|
|
Takashi Iwai |
b66ca0 |
--- a/sound/soc/soc-ops.c
|
|
Takashi Iwai |
b66ca0 |
+++ b/sound/soc/soc-ops.c
|
|
Takashi Iwai |
b66ca0 |
@@ -526,7 +526,7 @@ int snd_soc_put_volsw_range(struct snd_kcontrol *kcontrol,
|
|
Takashi Iwai |
b66ca0 |
return -EINVAL;
|
|
Takashi Iwai |
b66ca0 |
if (mc->platform_max && tmp > mc->platform_max)
|
|
Takashi Iwai |
b66ca0 |
return -EINVAL;
|
|
Takashi Iwai |
b66ca0 |
- if (tmp > mc->max - mc->min + 1)
|
|
Takashi Iwai |
b66ca0 |
+ if (tmp > mc->max - mc->min)
|
|
Takashi Iwai |
b66ca0 |
return -EINVAL;
|
|
Takashi Iwai |
b66ca0 |
|
|
Takashi Iwai |
b66ca0 |
if (invert)
|
|
Takashi Iwai |
b66ca0 |
@@ -547,7 +547,7 @@ int snd_soc_put_volsw_range(struct snd_kcontrol *kcontrol,
|
|
Takashi Iwai |
b66ca0 |
return -EINVAL;
|
|
Takashi Iwai |
b66ca0 |
if (mc->platform_max && tmp > mc->platform_max)
|
|
Takashi Iwai |
b66ca0 |
return -EINVAL;
|
|
Takashi Iwai |
b66ca0 |
- if (tmp > mc->max - mc->min + 1)
|
|
Takashi Iwai |
b66ca0 |
+ if (tmp > mc->max - mc->min)
|
|
Takashi Iwai |
b66ca0 |
return -EINVAL;
|
|
Takashi Iwai |
b66ca0 |
|
|
Takashi Iwai |
b66ca0 |
if (invert)
|
|
Takashi Iwai |
b66ca0 |
--
|
|
Takashi Iwai |
b66ca0 |
2.35.3
|
|
Takashi Iwai |
b66ca0 |
|