Takashi Iwai 636a7d
From 1e9ac114c4428fdb7ff4635b45d4f46017e8916f Mon Sep 17 00:00:00 2001
Takashi Iwai 636a7d
From: Zheng Wang <zyytlz.wz@163.com>
Takashi Iwai 636a7d
Date: Thu, 9 Mar 2023 16:07:39 +0800
Takashi Iwai 636a7d
Subject: [PATCH] Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work
Takashi Iwai 636a7d
Git-commit: 1e9ac114c4428fdb7ff4635b45d4f46017e8916f
Takashi Iwai 636a7d
Patch-mainline: v6.3-rc4
Takashi Iwai 636a7d
References: CVE-2023-1989 bsc#1210336
Takashi Iwai 636a7d
Takashi Iwai 636a7d
In btsdio_probe, &data->work was bound with btsdio_work.In
Takashi Iwai 636a7d
btsdio_send_frame, it was started by schedule_work.
Takashi Iwai 636a7d
Takashi Iwai 636a7d
If we call btsdio_remove with an unfinished job, there may
Takashi Iwai 636a7d
be a race condition and cause UAF bug on hdev.
Takashi Iwai 636a7d
Takashi Iwai 636a7d
Fixes: ddbaf13e3609 ("[Bluetooth] Add generic driver for Bluetooth SDIO devices")
Takashi Iwai 636a7d
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Takashi Iwai 636a7d
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Takashi Iwai 636a7d
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 636a7d
Takashi Iwai 636a7d
---
Takashi Iwai 636a7d
 drivers/bluetooth/btsdio.c | 1 +
Takashi Iwai 636a7d
 1 file changed, 1 insertion(+)
Takashi Iwai 636a7d
Takashi Iwai 636a7d
diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
Takashi Iwai 636a7d
index 795be33f2892..02893600db39 100644
Takashi Iwai 636a7d
--- a/drivers/bluetooth/btsdio.c
Takashi Iwai 636a7d
+++ b/drivers/bluetooth/btsdio.c
Takashi Iwai 636a7d
@@ -354,6 +354,7 @@ static void btsdio_remove(struct sdio_func *func)
Takashi Iwai 636a7d
 
Takashi Iwai 636a7d
 	BT_DBG("func %p", func);
Takashi Iwai 636a7d
 
Takashi Iwai 636a7d
+	cancel_work_sync(&data->work);
Takashi Iwai 636a7d
 	if (!data)
Takashi Iwai 636a7d
 		return;
Takashi Iwai 636a7d
 
Takashi Iwai 636a7d
-- 
Takashi Iwai 636a7d
2.35.3
Takashi Iwai 636a7d