From 29f316a1d7e0a570be9a47fa283ece53a67cebb7 Mon Sep 17 00:00:00 2001

From: Takahiro Fujii <fujii@xaxxi.net>

Date: Fri, 20 Jan 2023 03:30:02 +0900

Subject: [PATCH] HID: elecom: add support for TrackBall 056E:011C

Git-commit: 29f316a1d7e0a570be9a47fa283ece53a67cebb7

Patch-mainline: v6.2-rc8

References: git-fixes

Make function buttons on ELECOM M-HT1DRBK trackball mouse work. This model

has two devices with different device IDs (010D and 011C). Both of

them misreports the number of buttons as 5 in the report descriptor, even

though they have 8 buttons. hid-elecom overwrites the report to fix them,

but supports only on 010D and does not work on 011C. This patch fixes

011C in the similar way but with specialized position parameters.

In fact, it is sufficient to rewrite only 17th byte (05 -> 08). However I

followed the existing way.

Signed-off-by: Takahiro Fujii <fujii@xaxxi.net>

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/hid/hid-elecom.c | 16 ++++++++++++++--

 drivers/hid/hid-ids.h    |  3 ++-

 drivers/hid/hid-quirks.c |  3 ++-

 3 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/drivers/hid/hid-elecom.c b/drivers/hid/hid-elecom.c

index e59e9911fc37..4fa45ee77503 100644

--- a/drivers/hid/hid-elecom.c

+++ b/drivers/hid/hid-elecom.c

@@ -12,6 +12,7 @@

  *  Copyright (c) 2017 Alex Manoussakis <amanou@gnu.org>

  *  Copyright (c) 2017 Tomasz Kramkowski <tk@the-tk.com>

  *  Copyright (c) 2020 YOSHIOKA Takuma <lo48576@hard-wi.red>

+ *  Copyright (c) 2022 Takahiro Fujii <fujii@xaxxi.net>

  */

 /*

@@ -89,7 +90,7 @@ static __u8 *elecom_report_fixup(struct hid_device *hdev, __u8 *rdesc,

 	case USB_DEVICE_ID_ELECOM_M_DT1URBK:

 	case USB_DEVICE_ID_ELECOM_M_DT1DRBK:

 	case USB_DEVICE_ID_ELECOM_M_HT1URBK:

-	case USB_DEVICE_ID_ELECOM_M_HT1DRBK:

+	case USB_DEVICE_ID_ELECOM_M_HT1DRBK_010D:

 		/*

 		 * Report descriptor format:

 		 * 12: button bit count

@@ -99,6 +100,16 @@ static __u8 *elecom_report_fixup(struct hid_device *hdev, __u8 *rdesc,

 		 */

 		mouse_button_fixup(hdev, rdesc, *rsize, 12, 30, 14, 20, 8);

 		break;

+	case USB_DEVICE_ID_ELECOM_M_HT1DRBK_011C:

+		/*

+		 * Report descriptor format:

+		 * 22: button bit count

+		 * 30: padding bit count

+		 * 24: button report size

+		 * 16: button usage maximum

+		 */

+		mouse_button_fixup(hdev, rdesc, *rsize, 22, 30, 24, 16, 8);

+		break;

 	}

 	return rdesc;

 }

@@ -112,7 +123,8 @@ static const struct hid_device_id elecom_devices[] = {

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_DT1URBK) },

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_DT1DRBK) },

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1URBK) },

-	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1DRBK) },

+	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1DRBK_010D) },

+	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1DRBK_011C) },

 	{ }

 };

 MODULE_DEVICE_TABLE(hid, elecom_devices);

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h

index 0f8c11842a3a..d01d798ebedc 100644

--- a/drivers/hid/hid-ids.h

+++ b/drivers/hid/hid-ids.h

@@ -428,7 +428,8 @@

 #define USB_DEVICE_ID_ELECOM_M_DT1URBK	0x00fe

 #define USB_DEVICE_ID_ELECOM_M_DT1DRBK	0x00ff

 #define USB_DEVICE_ID_ELECOM_M_HT1URBK	0x010c

-#define USB_DEVICE_ID_ELECOM_M_HT1DRBK	0x010d

+#define USB_DEVICE_ID_ELECOM_M_HT1DRBK_010D	0x010d

+#define USB_DEVICE_ID_ELECOM_M_HT1DRBK_011C	0x011c

 #define USB_VENDOR_ID_DREAM_CHEEKY	0x1d34

 #define USB_DEVICE_ID_DREAM_CHEEKY_WN	0x0004

diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c

index be3ad02573de..5bc91f68b374 100644

--- a/drivers/hid/hid-quirks.c

+++ b/drivers/hid/hid-quirks.c

@@ -393,7 +393,8 @@ static const struct hid_device_id hid_have_special_driver[] = {

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_DT1URBK) },

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_DT1DRBK) },

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1URBK) },

-	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1DRBK) },

+	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1DRBK_010D) },

+	{ HID_USB_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_M_HT1DRBK_011C) },

 #endif

 #if IS_ENABLED(CONFIG_HID_ELO)

 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELO, 0x0009) },

-- 

2.35.3