From c874ad879c2f29ebe040a34b974389875c0d81eb Mon Sep 17 00:00:00 2001

From: Kang Chen <void0red@gmail.com>

Date: Mon, 27 Feb 2023 18:02:12 +0800

Subject: [PATCH 1/1] IB/hifi1: add a null check of kzalloc_node in

 hfi1_ipoib_txreq_init

Git-commit: c874ad879c2f29ebe040a34b974389875c0d81eb

Patch-mainline: v6.4-rc1

References: git-fixes

kzalloc_node may fails, check it and do the cleanup.

Fixes: b1151b74ff68 ("IB/hfi1: Fix alloc failure with larger txqueuelen")

Signed-off-by: Kang Chen <void0red@gmail.com>

Link: https://lore.kernel.org/r/20230227100212.910820-1-void0red@gmail.com

Signed-off-by: Leon Romanovsky <leon@kernel.org>

Acked-by: Nicolas Morey <nmorey@suse.com>

---

 drivers/infiniband/hw/hfi1/ipoib_tx.c | 5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c b/drivers/infiniband/hw/hfi1/ipoib_tx.c

index 5d9a7b09ca37..349eb4139136 100644

--- a/drivers/infiniband/hw/hfi1/ipoib_tx.c

+++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c

@@ -737,10 +737,13 @@ int hfi1_ipoib_txreq_init(struct hfi1_ipoib_dev_priv *priv)

 		txq->tx_ring.shift = ilog2(tx_item_size);

 		txq->tx_ring.avail = hfi1_ipoib_ring_hwat(txq);

 		tx_ring = &txq->tx_ring;

-		for (j = 0; j < tx_ring_size; j++)

+		for (j = 0; j < tx_ring_size; j++) {

 			hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr =

 				kzalloc_node(sizeof(*tx->sdma_hdr),

 					     GFP_KERNEL, priv->dd->node);

+			if (!hfi1_txreq_from_idx(tx_ring, j)->sdma_hdr)

+				goto free_txqs;

+		}

 		netif_tx_napi_add(dev, &txq->napi,

 				  hfi1_ipoib_poll_tx_ring,

-- 

2.39.1.1.gbe015eda0162