Matthias Brugger 9e5892
From: Marc Zyngier <maz@kernel.org>
Matthias Brugger 9e5892
Date: Tue, 15 Sep 2020 11:42:18 +0100
Matthias Brugger 9e5892
Subject: KVM: arm64: Remove S1PTW check from kvm_vcpu_dabt_iswrite()
Matthias Brugger 9e5892
Git-commit: 620cf45f7a516bf5fe9e5dce675a652e935c8bde
Matthias Brugger 9e5892
Patch-mainline: v5.9-rc7
Matthias Brugger 9e5892
References: bsc#1181818
Matthias Brugger 9e5892
Matthias Brugger 9e5892
Now that kvm_vcpu_trap_is_write_fault() checks for S1PTW, there
Matthias Brugger 9e5892
is no need for kvm_vcpu_dabt_iswrite() to do the same thing, as
Matthias Brugger 9e5892
we already check for this condition on all existing paths.
Matthias Brugger 9e5892
Matthias Brugger 9e5892
Drop the check and add a comment instead.
Matthias Brugger 9e5892
Matthias Brugger 9e5892
Signed-off-by: Marc Zyngier <maz@kernel.org>
Matthias Brugger 9e5892
Reviewed-by: Will Deacon <will@kernel.org>
Matthias Brugger 9e5892
Link: https://lore.kernel.org/r/20200915104218.1284701-3-maz@kernel.org
Matthias Brugger 9e5892
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Matthias Brugger 9e5892
---
Matthias Brugger 9e5892
 arch/arm64/include/asm/kvm_emulate.h |    3 +--
Matthias Brugger 9e5892
 1 file changed, 1 insertion(+), 2 deletions(-)
Matthias Brugger 9e5892
Matthias Brugger 9e5892
--- a/arch/arm64/include/asm/kvm_emulate.h
Matthias Brugger 9e5892
+++ b/arch/arm64/include/asm/kvm_emulate.h
Matthias Brugger 9e5892
@@ -307,8 +307,7 @@ static inline bool kvm_vcpu_abt_iss1tw(c
Matthias Brugger 9e5892
 
Matthias Brugger 9e5892
 static inline bool kvm_vcpu_dabt_iswrite(const struct kvm_vcpu *vcpu)
Matthias Brugger 9e5892
 {
Matthias Brugger 9e5892
-	return !!(kvm_vcpu_get_hsr(vcpu) & ESR_ELx_WNR) ||
Matthias Brugger 9e5892
-		kvm_vcpu_abt_iss1tw(vcpu); /* AF/DBM update */
Matthias Brugger 9e5892
+	return kvm_vcpu_get_hsr(vcpu) & ESR_ELx_WNR;
Matthias Brugger 9e5892
 }
Matthias Brugger 9e5892
 
Matthias Brugger 9e5892
 static inline bool kvm_vcpu_dabt_is_cm(const struct kvm_vcpu *vcpu)