Juergen Gross 1ff090
Patch-mainline: v4.20-rc5
Juergen Gross 1ff090
Git-commit: 354cb410d87314e2eda344feea84809e4261570a
Juergen Gross 1ff090
References: git-fixes
Juergen Gross 1ff090
From: Yi Wang <wang.yi59@zte.com.cn>
Juergen Gross 1ff090
Date: Thu, 8 Nov 2018 16:48:36 +0800
Juergen Gross 1ff090
Subject: [PATCH] KVM: x86: fix empty-body warnings
Juergen Gross 1ff090
MIME-Version: 1.0
Juergen Gross 1ff090
Content-Type: text/plain; charset=UTF-8
Juergen Gross 1ff090
Content-Transfer-Encoding: 8bit
Juergen Gross 1ff090
Juergen Gross 1ff090
We get the following warnings about empty statements when building
Juergen Gross 1ff090
with 'W=1':
Juergen Gross 1ff090
Juergen Gross 1ff090
arch/x86/kvm/lapic.c:632:53: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Juergen Gross 1ff090
arch/x86/kvm/lapic.c:1907:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Juergen Gross 1ff090
arch/x86/kvm/lapic.c:1936:65: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Juergen Gross 1ff090
arch/x86/kvm/lapic.c:1975:44: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Juergen Gross 1ff090
Juergen Gross 1ff090
Rework the debug helper macro to get rid of these warnings.
Juergen Gross 1ff090
Juergen Gross 1ff090
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Juergen Gross 1ff090
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Juergen Gross 1ff090
Signed-off-by: Juergen Gross <jgross@suse.com>
Juergen Gross 1ff090
---
Juergen Gross 1ff090
 arch/x86/kvm/lapic.c | 2 +-
Juergen Gross 1ff090
 1 file changed, 1 insertion(+), 1 deletion(-)
Juergen Gross 1ff090
Juergen Gross 1ff090
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
Juergen Gross 1ff090
index 02f2291dcf7e..c4533d05c214 100644
Juergen Gross 1ff090
--- a/arch/x86/kvm/lapic.c
Juergen Gross 1ff090
+++ b/arch/x86/kvm/lapic.c
Juergen Gross 1ff090
@@ -55,7 +55,7 @@
Juergen Gross 1ff090
 #define PRIo64 "o"
Juergen Gross 1ff090
 
Juergen Gross 1ff090
 /* #define apic_debug(fmt,arg...) printk(KERN_WARNING fmt,##arg) */
Juergen Gross 1ff090
-#define apic_debug(fmt, arg...)
Juergen Gross 1ff090
+#define apic_debug(fmt, arg...) do {} while (0)
Juergen Gross 1ff090
 
Juergen Gross 1ff090
 /* 14 is the version for Xeon and Pentium 8.4.8*/
Juergen Gross 1ff090
 #define APIC_VERSION			(0x14UL | ((KVM_APIC_LVT_NUM - 1) << 16))
Juergen Gross 1ff090
-- 
Juergen Gross 1ff090
2.35.3
Juergen Gross 1ff090