From 16f7ae5906dfbeff54f74ec75d0563bb3a87ab0b Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <arnd@arndb.de>

Date: Mon, 8 Mar 2021 16:24:47 +0100

Subject: [PATCH] PCI: thunder: Fix compile testing

Git-commit: 16f7ae5906dfbeff54f74ec75d0563bb3a87ab0b

Patch-mainline: v5.13-rc1

References: git-fixes

Compile-testing these drivers is currently broken. Enabling it causes a

couple of build failures though:

  drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow]

  drivers/pci/controller/pci-thunder-pem.c:54:2: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration]

  drivers/pci/controller/pci-thunder-pem.c:392:8: error: implicit declaration of function 'acpi_get_rc_resources' [-Werror,-Wimplicit-function-declaration]

Fix them with the obvious one-line changes.

Link: https://lore.kernel.org/r/20210308152501.2135937-2-arnd@kernel.org

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Reviewed-by: Robert Richter <rric@kernel.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/pci/controller/pci-thunder-ecam.c |    2 +-

 drivers/pci/controller/pci-thunder-pem.c  |   13 +++++++------

 drivers/pci/pci.h                         |    6 ++++++

 3 files changed, 14 insertions(+), 7 deletions(-)

--- a/drivers/pci/controller/pci-thunder-ecam.c

+++ b/drivers/pci/controller/pci-thunder-ecam.c

@@ -116,7 +116,7 @@ static int thunder_ecam_p2_config_read(s

 	 * the config space access window.  Since we are working with

 	 * the high-order 32 bits, shift everything down by 32 bits.

 	 */

-	node_bits = (cfg->res.start >> 32) & (1 << 12);

+	node_bits = upper_32_bits(cfg->res.start) & (1 << 12);

 	v |= node_bits;

 	set_val(v, where, size, val);

--- a/drivers/pci/controller/pci-thunder-pem.c

+++ b/drivers/pci/controller/pci-thunder-pem.c

@@ -11,6 +11,7 @@

 #include <linux/pci-acpi.h>

 #include <linux/pci-ecam.h>

 #include <linux/platform_device.h>

+#include <linux/io-64-nonatomic-lo-hi.h>

 #include "../pci.h"

 #if defined(CONFIG_PCI_HOST_THUNDER_PEM) || (defined(CONFIG_ACPI) && defined(CONFIG_PCI_QUIRKS))

@@ -314,9 +315,9 @@ static int thunder_pem_init(struct devic

 	 * structure here for the BAR.

 	 */

 	bar4_start = res_pem->start + 0xf00000;

-	pem_pci->ea_entry[0] = (u32)bar4_start | 2;

-	pem_pci->ea_entry[1] = (u32)(res_pem->end - bar4_start) & ~3u;

-	pem_pci->ea_entry[2] = (u32)(bar4_start >> 32);

+	pem_pci->ea_entry[0] = lower_32_bits(bar4_start) | 2;

+	pem_pci->ea_entry[1] = lower_32_bits(res_pem->end - bar4_start) & ~3u;

+	pem_pci->ea_entry[2] = upper_32_bits(bar4_start);

 	cfg->priv = pem_pci;

 	return 0;

@@ -324,9 +325,9 @@ static int thunder_pem_init(struct devic

 #if defined(CONFIG_ACPI) && defined(CONFIG_PCI_QUIRKS)

-#define PEM_RES_BASE		0x87e0c0000000UL

-#define PEM_NODE_MASK		GENMASK(45, 44)

-#define PEM_INDX_MASK		GENMASK(26, 24)

+#define PEM_RES_BASE		0x87e0c0000000ULL

+#define PEM_NODE_MASK		GENMASK_ULL(45, 44)

+#define PEM_INDX_MASK		GENMASK_ULL(26, 24)

 #define PEM_MIN_DOM_IN_NODE	4

 #define PEM_MAX_DOM_IN_NODE	10

--- a/drivers/pci/pci.h

+++ b/drivers/pci/pci.h

@@ -575,6 +575,12 @@ static inline int pci_dev_specific_reset

 #if defined(CONFIG_PCI_QUIRKS) && defined(CONFIG_ARM64)

 int acpi_get_rc_resources(struct device *dev, const char *hid, u16 segment,

 			  struct resource *res);

+#else

+static inline int acpi_get_rc_resources(struct device *dev, const char *hid,

+					u16 segment, struct resource *res)

+{

+	return -ENODEV;

+}

 #endif

 u32 pci_rebar_get_possible_sizes(struct pci_dev *pdev, int bar);