From: Mustafa Ismail <mustafa.ismail@intel.com>

Date: Wed, 15 Mar 2023 09:52:28 -0500

Subject: RDMA/irdma: Do not generate SW completions for NOPs

Patch-mainline: v6.3-rc7

Git-commit: 30ed9ee9a10a90ae719dcfcacead1d0506fa45ed

References: jsc#SLE-18383

Currently, artificial SW completions are generated for NOP wqes which can

generate unexpected completions with wr_id = 0. Skip the generation of

artificial completions for NOPs.

Fixes: 81091d7696ae ("RDMA/irdma: Add SW mechanism to generate completions on error")

Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>

Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>

Link: https://lore.kernel.org/r/20230315145231.931-2-shiraz.saleem@intel.com

Signed-off-by: Leon Romanovsky <leon@kernel.org>

Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

---

 drivers/infiniband/hw/irdma/utils.c |    5 ++++-

 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/infiniband/hw/irdma/utils.c

+++ b/drivers/infiniband/hw/irdma/utils.c

@@ -2594,7 +2594,10 @@ void irdma_generate_flush_completions(st

 			/* remove the SQ WR by moving SQ tail*/

 			IRDMA_RING_SET_TAIL(*sq_ring,

 				sq_ring->tail + qp->sq_wrtrk_array[sq_ring->tail].quanta);

-

+			if (cmpl->cpi.op_type == IRDMAQP_OP_NOP) {

+				kfree(cmpl);

+				continue;

+			}

 			ibdev_dbg(iwqp->iwscq->ibcq.device,

 				  "DEV: %s: adding wr_id = 0x%llx SQ Completion to list qp_id=%d\n",

 				  __func__, cmpl->cpi.wr_id, qp->qp_id);