From 8d1beda5f11953ffe135a5213287f0b25b4da41b Mon Sep 17 00:00:00 2001

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Date: Mon, 3 May 2021 13:56:35 +0200

Subject: [PATCH] Revert "leds: lp5523: fix a missing check of return value of lp55xx_read"

Git-commit: 8d1beda5f11953ffe135a5213287f0b25b4da41b

Patch-mainline: v5.13-rc3

References: git-fixes

This reverts commit 248b57015f35c94d4eae2fdd8c6febf5cd703900.

Because of recent interactions with developers from @umn.edu, all

commits from them have been recently re-reviewed to ensure if they were

correct or not.

Upon review, this commit was found to be incorrect for the reasons

below, so it must be reverted.  It will be fixed up "correctly" in a

later kernel change.

The original commit does not properly unwind if there is an error

condition so it needs to be reverted at this point in time.

Cc: Kangjie Lu <kjlu@umn.edu>

Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>

Cc: stable <stable@vger.kernel.org>

Fixes: 248b57015f35 ("leds: lp5523: fix a missing check of return value of lp55xx_read")

Link: https://lore.kernel.org/r/20210503115736.2104747-9-gregkh@linuxfoundation.org

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/leds/leds-lp5523.c | 4 +---

 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c

index fc433e63b1dc..5036d7d5f3d4 100644

--- a/drivers/leds/leds-lp5523.c

+++ b/drivers/leds/leds-lp5523.c

@@ -305,9 +305,7 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip)

 	/* Let the programs run for couple of ms and check the engine status */

 	usleep_range(3000, 6000);

-	ret = lp55xx_read(chip, LP5523_REG_STATUS, &status);

-	if (ret)

-		return ret;

+	lp55xx_read(chip, LP5523_REG_STATUS, &status);

 	status &= LP5523_ENG_STATUS_MASK;

 	if (status != LP5523_ENG_STATUS_MASK) {

-- 

2.26.2