From 0dc267b13f3a7e8424a898815dd357211b737330 Mon Sep 17 00:00:00 2001

From: Wen Gong <wgong@codeaurora.org>

Date: Tue, 11 May 2021 20:02:56 +0200

Subject: [PATCH] ath10k: Fix TKIP Michael MIC verification for PCIe

Git-commit: 0dc267b13f3a7e8424a898815dd357211b737330

Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git

Patch-mainline: Queued in subsystem maintainer repo

References: CVE-2020-26141 bsc#1185863 bsc#1185987

TKIP Michael MIC was not verified properly for PCIe cases since the

validation steps in ieee80211_rx_h_michael_mic_verify() in mac80211 did

not get fully executed due to unexpected flag values in

ieee80211_rx_status.

Fix this by setting the flags property to meet mac80211 expectations for

performing Michael MIC validation there. This fixes CVE-2020-26141. It

does the same as ath10k_htt_rx_proc_rx_ind_hl() for SDIO which passed

MIC verification case. This applies only to QCA6174/QCA9377 PCIe.

Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1

Cc: stable@vger.kernel.org

Signed-off-by: Wen Gong <wgong@codeaurora.org>

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

Link: https://lore.kernel.org/r/20210511200110.c3f1d42c6746.I795593fcaae941c471425b8c7d5f7bb185d29142@changeid

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/net/wireless/ath/ath10k/htt_rx.c |    8 ++++++++

 1 file changed, 8 insertions(+)

--- a/drivers/net/wireless/ath/ath10k/htt_rx.c

+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c

@@ -1425,6 +1425,10 @@ static void ath10k_htt_rx_h_mpdu(struct

 		}

 		ath10k_htt_rx_h_csum_offload(msdu);

+

+		if (frag && enctype == HTT_RX_MPDU_ENCRYPT_TKIP_WPA)

+			status->flag &= ~RX_FLAG_MMIC_STRIPPED;

+

 		ath10k_htt_rx_h_undecap(ar, msdu, status, first_hdr, enctype,

 					is_decrypted);

@@ -1439,6 +1443,10 @@ static void ath10k_htt_rx_h_mpdu(struct

 		hdr = (void *)msdu->data;

 		hdr->frame_control &= ~__cpu_to_le16(IEEE80211_FCTL_PROTECTED);

+

+		if (frag && enctype == HTT_RX_MPDU_ENCRYPT_TKIP_WPA)

+			status->flag &= ~RX_FLAG_IV_STRIPPED &

+					~RX_FLAG_MMIC_STRIPPED;

 	}

 }