From: Jiri Olsa <jolsa@kernel.org>

Date: Wed, 30 Mar 2022 13:05:10 +0200

Subject: bpf: Fix sparse warnings in kprobe_multi_resolve_syms

Patch-mainline: v5.18-rc2

Git-commit: d31e0386a2f122b40b605eb0120a2fbcfca77868

References: jsc#PED-1377

Adding missing __user tags to fix sparse warnings:

kernel/trace/bpf_trace.c:2370:34: warning: incorrect type in argument 2 (different address spaces)

kernel/trace/bpf_trace.c:2370:34:    expected void const [noderef] __user *from

kernel/trace/bpf_trace.c:2370:34:    got void const *usyms

kernel/trace/bpf_trace.c:2376:51: warning: incorrect type in argument 2 (different address spaces)

kernel/trace/bpf_trace.c:2376:51:    expected char const [noderef] __user *src

kernel/trace/bpf_trace.c:2376:51:    got char const *

kernel/trace/bpf_trace.c:2443:49: warning: incorrect type in argument 1 (different address spaces)

kernel/trace/bpf_trace.c:2443:49:    expected void const *usyms

kernel/trace/bpf_trace.c:2443:49:    got void [noderef] __user *[assigned] usyms

Fixes: 0dcac2725406 ("bpf: Add multi kprobe link")

Reported-by: Alexei Starovoitov <ast@kernel.org>

Reported-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Link: https://lore.kernel.org/bpf/20220330110510.398558-1-jolsa@kernel.org

Acked-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>

---

 kernel/trace/bpf_trace.c |    4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/trace/bpf_trace.c

+++ b/kernel/trace/bpf_trace.c

@@ -2354,11 +2354,11 @@ kprobe_multi_link_handler(struct fprobe

 }

 static int

-kprobe_multi_resolve_syms(const void *usyms, u32 cnt,

+kprobe_multi_resolve_syms(const void __user *usyms, u32 cnt,

 			  unsigned long *addrs)

 {

 	unsigned long addr, size;

-	const char **syms;

+	const char __user **syms;

 	int err = -ENOMEM;

 	unsigned int i;

 	char *func;