|
Takashi Iwai |
bfa7eb |
From e879f855e590b40fe3c79f2fbd8f65ca3c724120 Mon Sep 17 00:00:00 2001
|
|
Takashi Iwai |
bfa7eb |
From: Nathan Chancellor <nathan@kernel.org>
|
|
Takashi Iwai |
bfa7eb |
Date: Sun, 15 Aug 2021 12:18:52 -0700
|
|
Takashi Iwai |
bfa7eb |
Subject: [PATCH] bus: ti-sysc: Add break in switch statement in sysc_init_soc()
|
|
Takashi Iwai |
bfa7eb |
Git-commit: e879f855e590b40fe3c79f2fbd8f65ca3c724120
|
|
Takashi Iwai |
bfa7eb |
Patch-mainline: v5.15-rc5
|
|
Takashi Iwai |
5952e9 |
References: git-fixes stable-5.14.12
|
|
Takashi Iwai |
bfa7eb |
|
|
Takashi Iwai |
bfa7eb |
After commit a6d90e9f2232 ("bus: ti-sysc: AM3: RNG is GP only"), clang
|
|
Takashi Iwai |
bfa7eb |
with -Wimplicit-fallthrough enabled warns:
|
|
Takashi Iwai |
bfa7eb |
|
|
Takashi Iwai |
bfa7eb |
drivers/bus/ti-sysc.c:2958:3: warning: unannotated fall-through between
|
|
Takashi Iwai |
bfa7eb |
switch labels [-Wimplicit-fallthrough]
|
|
Takashi Iwai |
bfa7eb |
default:
|
|
Takashi Iwai |
bfa7eb |
^
|
|
Takashi Iwai |
bfa7eb |
drivers/bus/ti-sysc.c:2958:3: note: insert 'break;' to avoid
|
|
Takashi Iwai |
bfa7eb |
fall-through
|
|
Takashi Iwai |
bfa7eb |
default:
|
|
Takashi Iwai |
bfa7eb |
^
|
|
Takashi Iwai |
bfa7eb |
break;
|
|
Takashi Iwai |
bfa7eb |
1 warning generated.
|
|
Takashi Iwai |
bfa7eb |
|
|
Takashi Iwai |
bfa7eb |
Clang's version of this warning is a little bit more pedantic than
|
|
Takashi Iwai |
bfa7eb |
GCC's. Add the missing break to satisfy it to match what has been done
|
|
Takashi Iwai |
bfa7eb |
all over the kernel tree.
|
|
Takashi Iwai |
bfa7eb |
|
|
Takashi Iwai |
bfa7eb |
Fixes: a6d90e9f2232 ("bus: ti-sysc: AM3: RNG is GP only")
|
|
Takashi Iwai |
bfa7eb |
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
|
|
Takashi Iwai |
bfa7eb |
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
|
|
Takashi Iwai |
bfa7eb |
Signed-off-by: Tony Lindgren <tony@atomide.com>
|
|
Takashi Iwai |
bfa7eb |
Acked-by: Takashi Iwai <tiwai@suse.de>
|
|
Takashi Iwai |
bfa7eb |
|
|
Takashi Iwai |
bfa7eb |
---
|
|
Takashi Iwai |
bfa7eb |
drivers/bus/ti-sysc.c | 1 +
|
|
Takashi Iwai |
bfa7eb |
1 file changed, 1 insertion(+)
|
|
Takashi Iwai |
bfa7eb |
|
|
Takashi Iwai |
bfa7eb |
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
|
|
Takashi Iwai |
bfa7eb |
index 148a4dd8cb9a..10fcb75df68a 100644
|
|
Takashi Iwai |
bfa7eb |
--- a/drivers/bus/ti-sysc.c
|
|
Takashi Iwai |
bfa7eb |
+++ b/drivers/bus/ti-sysc.c
|
|
Takashi Iwai |
bfa7eb |
@@ -2955,6 +2955,7 @@ static int sysc_init_soc(struct sysc *ddata)
|
|
Takashi Iwai |
bfa7eb |
break;
|
|
Takashi Iwai |
bfa7eb |
case SOC_AM3:
|
|
Takashi Iwai |
bfa7eb |
sysc_add_disabled(0x48310000); /* rng */
|
|
Takashi Iwai |
bfa7eb |
+ break;
|
|
Takashi Iwai |
bfa7eb |
default:
|
|
Takashi Iwai |
bfa7eb |
break;
|
|
Takashi Iwai |
bfa7eb |
}
|
|
Takashi Iwai |
bfa7eb |
--
|
|
Takashi Iwai |
bfa7eb |
2.26.2
|
|
Takashi Iwai |
bfa7eb |
|