From: Xiubo Li <xiubli@redhat.com>

Date: Fri, 27 May 2022 12:39:17 +0800

Subject: ceph: choose auth MDS for getxattr with the Xs caps

Git-commit: 8266c4d7a7469c3fd45ee2b4ebc01aac311c6c48

Patch-mainline: v6.0-rc1

References: jsc#SES-1880

And for the 'Xs' caps for getxattr we will also choose the auth MDS,

because the MDS side code is buggy due to setxattr won't notify the

replica MDSes when the values changed and the replica MDS will return

the old values. Though we will fix it in MDS code, but this still

makes sense for old ceph.

Link: https://tracker.ceph.com/issues/55331

Signed-off-by: Xiubo Li <xiubli@redhat.com>

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Acked-by: Luis Henriques <lhenriques@suse.com>

---

 fs/ceph/inode.c | 8 +++++++-

 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c

index 56c53ab3618e..1834d6529f25 100644

--- a/fs/ceph/inode.c

+++ b/fs/ceph/inode.c

@@ -2275,9 +2275,15 @@ int ceph_try_to_choose_auth_mds(struct inode *inode, int mask)

 	 *

 	 * This cost much when doing the Locker state transition and

 	 * usually will need to revoke caps from clients.

+	 *

+	 * And for the 'Xs' caps for getxattr we will also choose the

+	 * auth MDS, because the MDS side code is buggy due to setxattr

+	 * won't notify the replica MDSes when the values changed and

+	 * the replica MDS will return the old values. Though we will

+	 * fix it in MDS code, but this still makes sense for old ceph.

 	 */

 	if (((mask & CEPH_CAP_ANY_SHARED) && (issued & CEPH_CAP_ANY_EXCL))

-	    || (mask & CEPH_STAT_RSTAT))

+	    || (mask & (CEPH_STAT_RSTAT | CEPH_STAT_CAP_XATTR)))

 		return USE_AUTH_MDS;

 	else

 		return USE_ANY_MDS;