Luís Henriques bb0d57
From: Jeff Layton <jlayton@kernel.org>
Luís Henriques bb0d57
Date: Mon, 6 Jun 2022 19:31:42 -0400
Luís Henriques bb0d57
Subject: ceph: wait on async create before checking caps for syncfs
Luís Henriques bb0d57
Git-commit: 8692969e9164c15474b356b9898e5b9b21a85643
Luís Henriques bb0d57
Patch-mainline: v5.19-rc5
Luís Henriques bb0d57
References: jsc#SES-1880
Luís Henriques bb0d57
Luís Henriques bb0d57
Currently, we'll call ceph_check_caps, but if we're still waiting
Luís Henriques bb0d57
on the reply, we'll end up spinning around on the same inode in
Luís Henriques bb0d57
flush_dirty_session_caps. Wait for the async create reply before
Luís Henriques bb0d57
flushing caps.
Luís Henriques bb0d57
Luís Henriques bb0d57
Cc: stable@vger.kernel.org
Luís Henriques bb0d57
URL: https://tracker.ceph.com/issues/55823
Luís Henriques bb0d57
Fixes: fbed7045f552 ("ceph: wait for async create reply before sending any cap messages")
Luís Henriques bb0d57
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Luís Henriques bb0d57
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Luís Henriques bb0d57
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Luís Henriques bb0d57
Acked-by: Luis Henriques <lhenriques@suse.com>
Luís Henriques bb0d57
---
Luís Henriques bb0d57
 fs/ceph/caps.c | 1 +
Luís Henriques bb0d57
 1 file changed, 1 insertion(+)
Luís Henriques bb0d57
Luís Henriques bb0d57
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
Luís Henriques bb0d57
index 38c930384d41..ac8fd5e7f540 100644
Luís Henriques bb0d57
--- a/fs/ceph/caps.c
Luís Henriques bb0d57
+++ b/fs/ceph/caps.c
Luís Henriques bb0d57
@@ -4377,6 +4377,7 @@ static void flush_dirty_session_caps(struct ceph_mds_session *s)
Luís Henriques bb0d57
 		ihold(inode);
Luís Henriques bb0d57
 		dout("flush_dirty_caps %llx.%llx\n", ceph_vinop(inode));
Luís Henriques bb0d57
 		spin_unlock(&mdsc->cap_dirty_lock);
Luís Henriques bb0d57
+		ceph_wait_on_async_create(inode);
Luís Henriques bb0d57
 		ceph_check_caps(ci, CHECK_CAPS_FLUSH, NULL);
Luís Henriques bb0d57
 		iput(inode);
Luís Henriques bb0d57
 		spin_lock(&mdsc->cap_dirty_lock);
Luís Henriques bb0d57