From: Shyam Prasad N <sprasad@microsoft.com>

Date: Tue, 27 Dec 2022 11:29:28 +0000

Subject: [PATCH] cifs: refcount only the selected iface during interface

 update

Git-commit: 7246210ecdd0cda97fa3e3bb15c32c6c2d9a23b5

References: git-fixes

Patch-mainline: v6.2-rc3

When the server interface for a channel is not active anymore,

we have the logic to select an alternative interface. However

this was not breaking out of the loop as soon as a new alternative

was found. As a result, some interfaces may get refcounted unintentionally.

There was also a bug in checking if we found an alternate iface.

Fixed that too.

Fixes: b54034a73baf ("cifs: during reconnect, update interface if necessary")

Cc: stable@vger.kernel.org # 5.19+

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>

Signed-off-by: Steve French <stfrench@microsoft.com>

Acked-by: Paulo Alcantara <palcantara@suse.de>

---

 fs/cifs/sess.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c

index 9e7d9f0baa18..0b842a07e157 100644

--- a/fs/cifs/sess.c

+++ b/fs/cifs/sess.c

@@ -292,9 +292,10 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)

 			continue;

 		}

 		kref_get(&iface->refcount);

+		break;

 	}

-	if (!list_entry_is_head(iface, &ses->iface_list, iface_head)) {

+	if (list_entry_is_head(iface, &ses->iface_list, iface_head)) {

 		rc = 1;

 		iface = NULL;

 		cifs_dbg(FYI, "unable to find a suitable iface\n");

-- 

2.39.0