Takashi Iwai 0a4b52
From d1ff2559cef0f6f8d97fba6337b28adb10689e16 Mon Sep 17 00:00:00 2001
Takashi Iwai 0a4b52
From: Miaoqian Lin <linmq006@gmail.com>
Takashi Iwai 0a4b52
Date: Sun, 5 Jun 2022 12:28:07 +0400
Takashi Iwai 0a4b52
Subject: [PATCH] cpufreq: zynq: Fix refcount leak in zynq_get_revision
Takashi Iwai 0a4b52
Git-commit: d1ff2559cef0f6f8d97fba6337b28adb10689e16
Takashi Iwai 0a4b52
Patch-mainline: v6.0-rc1
Takashi Iwai 0a4b52
References: git-fixes
Takashi Iwai 0a4b52
Takashi Iwai 0a4b52
of_find_compatible_node() returns a node pointer with refcount
Takashi Iwai 0a4b52
incremented, we should use of_node_put() on it when done.
Takashi Iwai 0a4b52
Add missing of_node_put() to avoid refcount leak.
Takashi Iwai 0a4b52
Takashi Iwai 0a4b52
Fixes: 00f7dc636366 ("ARM: zynq: Add support for SOC_BUS")
Takashi Iwai 0a4b52
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Takashi Iwai 0a4b52
Link: https://lore.kernel.org/r/20220605082807.21526-1-linmq006@gmail.com
Takashi Iwai 0a4b52
Signed-off-by: Michal Simek <michal.simek@amd.com>
Takashi Iwai 0a4b52
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 0a4b52
Takashi Iwai 0a4b52
---
Takashi Iwai 0a4b52
 arch/arm/mach-zynq/common.c | 1 +
Takashi Iwai 0a4b52
 1 file changed, 1 insertion(+)
Takashi Iwai 0a4b52
Takashi Iwai 0a4b52
diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
Takashi Iwai 0a4b52
index e1ca6a5732d2..15e8a321a713 100644
Takashi Iwai 0a4b52
--- a/arch/arm/mach-zynq/common.c
Takashi Iwai 0a4b52
+++ b/arch/arm/mach-zynq/common.c
Takashi Iwai 0a4b52
@@ -77,6 +77,7 @@ static int __init zynq_get_revision(void)
Takashi Iwai 0a4b52
 	}
Takashi Iwai 0a4b52
 
Takashi Iwai 0a4b52
 	zynq_devcfg_base = of_iomap(np, 0);
Takashi Iwai 0a4b52
+	of_node_put(np);
Takashi Iwai 0a4b52
 	if (!zynq_devcfg_base) {
Takashi Iwai 0a4b52
 		pr_err("%s: Unable to map I/O memory\n", __func__);
Takashi Iwai 0a4b52
 		return -1;
Takashi Iwai 0a4b52
-- 
Takashi Iwai 0a4b52
2.35.3
Takashi Iwai 0a4b52