From 2acbb8771f6ac82422886e63832ee7a0f4b1635b Mon Sep 17 00:00:00 2001

From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Date: Mon, 9 May 2022 14:34:15 +0100

Subject: [PATCH] crypto: qat - add param check for DH

Git-commit: 2acbb8771f6ac82422886e63832ee7a0f4b1635b

Patch-mainline: v5.19-rc1

References: jsc#PED-1073

Reject requests with a source buffer that is bigger than the size of the

key. This is to prevent a possible integer underflow that might happen

when copying the source scatterlist into a linear buffer.

Cc: stable@vger.kernel.org

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Reviewed-by: Adam Guerin <adam.guerin@intel.com>

Reviewed-by: Wojciech Ziemba <wojciech.ziemba@intel.com>

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Torsten Duwe <duwe@suse.de>

---

 drivers/crypto/qat/qat_common/qat_asym_algs.c | 4 ++++

 1 file changed, 4 insertions(+)

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c

index 947eeff181b49..7173a2a0a484f 100644

--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c

+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c

@@ -235,6 +235,10 @@ static int qat_dh_compute_value(struct kpp_request *req)

 		req->dst_len = ctx->p_size;

 		return -EOVERFLOW;

 	}

+

+	if (req->src_len > ctx->p_size)

+		return -EINVAL;

+

 	memset(msg, '\0', sizeof(*msg));

 	ICP_QAT_FW_PKE_HDR_VALID_FLAG_SET(msg->pke_hdr,

 					  ICP_QAT_FW_COMN_REQ_FLAG_SET);

-- 

2.35.3