From 6f87979129d10cff5b4b0b49343720b99b5357b8 Mon Sep 17 00:00:00 2001

From: Marco Chiappero <marco.chiappero@intel.com>

Date: Thu, 16 Dec 2021 09:13:23 +0000

Subject: [PATCH] crypto: qat - improve the ACK timings in PFVF send

Git-commit: 6f87979129d10cff5b4b0b49343720b99b5357b8

Patch-mainline: v5.17-rc1

References: jsc#PED-1073

Review the ACK timings in adf_gen2_pfvf_send() to improve the latency

by reducing the polling interval. Also increase the timeout, for higher

tolerance in highly loaded systems, and reposition these new values to

allow for inclusion by the future GEN4 devices too.

Signed-off-by: Marco Chiappero <marco.chiappero@intel.com>

Co-developed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Reviewed-by: Fiona Trahe <fiona.trahe@intel.com>

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Torsten Duwe <duwe@suse.de>

---

 drivers/crypto/qat/qat_common/adf_gen2_pfvf.c  | 3 ---

 drivers/crypto/qat/qat_common/adf_pfvf_utils.h | 4 ++++

 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/adf_gen2_pfvf.c b/drivers/crypto/qat/qat_common/adf_gen2_pfvf.c

index 53c2e124944db..feab01ec4bbb3 100644

--- a/drivers/crypto/qat/qat_common/adf_gen2_pfvf.c

+++ b/drivers/crypto/qat/qat_common/adf_gen2_pfvf.c

@@ -37,9 +37,6 @@ static const struct pfvf_csr_format csr_gen2_fmt = {

 	{ ADF_PFVF_GEN2_MSGDATA_SHIFT, ADF_PFVF_GEN2_MSGDATA_MASK },

 };

-#define ADF_PFVF_MSG_ACK_DELAY_US	2000

-#define ADF_PFVF_MSG_ACK_MAX_DELAY_US	(ADF_PFVF_MSG_ACK_DELAY_US * 100)

-

 #define ADF_PFVF_MSG_RETRY_DELAY	5

 #define ADF_PFVF_MSG_MAX_RETRIES	3

diff --git a/drivers/crypto/qat/qat_common/adf_pfvf_utils.h b/drivers/crypto/qat/qat_common/adf_pfvf_utils.h

index 7b73b5992d031..7676fdddbe268 100644

--- a/drivers/crypto/qat/qat_common/adf_pfvf_utils.h

+++ b/drivers/crypto/qat/qat_common/adf_pfvf_utils.h

@@ -6,6 +6,10 @@

 #include <linux/types.h>

 #include "adf_pfvf_msg.h"

+/* How long to wait for far side to acknowledge receipt */

+#define ADF_PFVF_MSG_ACK_DELAY_US	4

+#define ADF_PFVF_MSG_ACK_MAX_DELAY_US	(1 * USEC_PER_SEC)

+

 struct pfvf_field_format {

 	u8  offset;

 	u32 mask;

-- 

2.35.3