From c700216c70fca38ae7ceff07ed63d79ae25379c5 Mon Sep 17 00:00:00 2001

From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Date: Fri, 4 Mar 2022 18:03:54 +0000

Subject: [PATCH] crypto: qat - remove unneeded assignment

Git-commit: c700216c70fca38ae7ceff07ed63d79ae25379c5

Patch-mainline: v5.18-rc1

References: jsc#PED-1073

The function adf_gen4_get_vf2pf_sources() computes a mask which is

stored in a variable which is returned and not used.

Remove superfluous assignment of variable.

This is to fix the following warning when compiling the QAT driver

with clang scan-build:

    drivers/crypto/qat/qat_common/adf_gen4_pfvf.c:46:9: warning: Although the value stored to 'sou' is used in the enclosing expression, the value is never actually read from 'sou' [deadcode.DeadStores]

            return sou &= ~mask;

                   ^      ~~~~~

Fixes: 5901b4af6e07 ("crypto: qat - fix access to PFVF interrupt registers for GEN4")

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Torsten Duwe <duwe@suse.de>

---

 drivers/crypto/qat/qat_common/adf_gen4_pfvf.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/adf_gen4_pfvf.c b/drivers/crypto/qat/qat_common/adf_gen4_pfvf.c

index 3b3ea849c5e53..d80d493a77568 100644

--- a/drivers/crypto/qat/qat_common/adf_gen4_pfvf.c

+++ b/drivers/crypto/qat/qat_common/adf_gen4_pfvf.c

@@ -43,7 +43,7 @@ static u32 adf_gen4_get_vf2pf_sources(void __iomem *pmisc_addr)

 	sou = ADF_CSR_RD(pmisc_addr, ADF_4XXX_VM2PF_SOU);

 	mask = ADF_CSR_RD(pmisc_addr, ADF_4XXX_VM2PF_MSK);

-	return sou &= ~mask;

+	return sou & ~mask;

 }

 static void adf_gen4_enable_vf2pf_interrupts(void __iomem *pmisc_addr,

-- 

2.35.3