From 40da865381ad061ab75a7a9da469ed4e623bdfeb Mon Sep 17 00:00:00 2001

From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Date: Thu, 2 Sep 2021 09:34:59 +0100

Subject: [PATCH] crypto: qat - remove unneeded packed attribute

Git-commit: 40da865381ad061ab75a7a9da469ed4e623bdfeb

Patch-mainline: v5.16-rc1

References: jsc#PED-1073

Remove packed attribute from structures that do not need to be packed.

These are just used internally and not shared with firmware.

This also fixes a series of warning when compiling the driver with the

flag -Waddress-of-packed-member, similar to the following:

    drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28: warning: taking address of packed member 'csr_ops' of class or structure 'adf_hw_device_data' may result in an unaligned pointer value

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Reported-by: kernel test robot <lkp@intel.com>

Reviewed-by: Wojciech Ziemba <wojciech.ziemba@intel.com>

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Torsten Duwe <duwe@suse.de>

---

 drivers/crypto/qat/qat_common/adf_accel_devices.h | 12 ++++++------

 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/adf_accel_devices.h b/drivers/crypto/qat/qat_common/adf_accel_devices.h

index e391ca0662bc5..b62b34fccc90d 100644

--- a/drivers/crypto/qat/qat_common/adf_accel_devices.h

+++ b/drivers/crypto/qat/qat_common/adf_accel_devices.h

@@ -42,7 +42,7 @@ struct adf_bar {

 	resource_size_t base_addr;

 	void __iomem *virt_addr;

 	resource_size_t size;

-} __packed;

+};

 struct adf_irq {

 	bool enabled;

@@ -52,7 +52,7 @@ struct adf_irq {

 struct adf_accel_msix {

 	struct adf_irq *irqs;

 	u32 num_entries;

-} __packed;

+};

 struct adf_accel_pci {

 	struct pci_dev *pci_dev;

@@ -60,7 +60,7 @@ struct adf_accel_pci {

 	struct adf_bar pci_bars[ADF_PCI_MAX_BARS];

 	u8 revid;

 	u8 sku;

-} __packed;

+};

 enum dev_state {

 	DEV_DOWN = 0,

@@ -100,7 +100,7 @@ struct adf_hw_device_class {

 	const char *name;

 	const enum adf_device_type type;

 	u32 instances;

-} __packed;

+};

 struct arb_info {

 	u32 arb_cfg;

@@ -199,7 +199,7 @@ struct adf_hw_device_data {

 	u8 num_logical_accel;

 	u8 num_engines;

 	u8 min_iov_compat_ver;

-} __packed;

+};

 /* CSR write macro */

 #define ADF_CSR_WR(csr_base, csr_offset, val) \

@@ -266,5 +266,5 @@ struct adf_accel_dev {

 	};

 	bool is_vf;

 	u32 accel_id;

-} __packed;

+};

 #endif

-- 

2.35.3