From 072d36eefd6fde17928d214df64fdac32f60b4f4 Mon Sep 17 00:00:00 2001

From: Damian Muszynski <damian.muszynski@intel.com>

Date: Fri, 9 Sep 2022 11:49:14 +0100

Subject: [PATCH] crypto: qat - use reference to structure in dma_map_single()

Git-commit: 072d36eefd6fde17928d214df64fdac32f60b4f4

Patch-mainline: v6.1-rc1

References: jsc#PED-1073

When mapping the input and output parameters, the implementations of RSA

and DH pass to the function dma_map_single() a pointer to the first

member of the structure they want to map instead of a pointer to the

actual structure.

This results in set of warnings reported by the static analyser Smatch:

    drivers/crypto/qat/qat_common/qat_asym_algs.c:335 qat_dh_compute_value() error: dma_map_single_attrs() '&qat_req->in.dh.in.b' too small (8 vs 64)

    drivers/crypto/qat/qat_common/qat_asym_algs.c:341 qat_dh_compute_value() error: dma_map_single_attrs() '&qat_req->out.dh.r' too small (8 vs 64)

    drivers/crypto/qat/qat_common/qat_asym_algs.c:732 qat_rsa_enc() error: dma_map_single_attrs() '&qat_req->in.rsa.enc.m' too small (8 vs 64)

    drivers/crypto/qat/qat_common/qat_asym_algs.c:738 qat_rsa_enc() error: dma_map_single_attrs() '&qat_req->out.rsa.enc.c' too small (8 vs 64)

    drivers/crypto/qat/qat_common/qat_asym_algs.c:878 qat_rsa_dec() error: dma_map_single_attrs() '&qat_req->in.rsa.dec.c' too small (8 vs 64)

    drivers/crypto/qat/qat_common/qat_asym_algs.c:884 qat_rsa_dec() error: dma_map_single_attrs() '&qat_req->out.rsa.dec.m' too small (8 vs 64)

Where the address of the first element of a structure is used as an

input for the function dma_map_single(), replace it with the address of

the structure. This fix does not introduce any functional change as the

addresses are the same.

Signed-off-by: Damian Muszynski <damian.muszynski@intel.com>

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Reviewed-by: Adam Guerin <adam.guerin@intel.com>

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Torsten Duwe <duwe@suse.de>

---

 drivers/crypto/qat/qat_common/qat_asym_algs.c | 12 ++++++------

 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c

index 85b0f30712e16..94a26702aeae1 100644

--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c

+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c

@@ -332,13 +332,13 @@ static int qat_dh_compute_value(struct kpp_request *req)

 	qat_req->in.dh.in_tab[n_input_params] = 0;

 	qat_req->out.dh.out_tab[1] = 0;

 	/* Mapping in.in.b or in.in_g2.xa is the same */

-	qat_req->phy_in = dma_map_single(dev, &qat_req->in.dh.in.b,

+	qat_req->phy_in = dma_map_single(dev, &qat_req->in.dh,

 					 sizeof(struct qat_dh_input_params),

 					 DMA_TO_DEVICE);

 	if (unlikely(dma_mapping_error(dev, qat_req->phy_in)))

 		goto unmap_dst;

-	qat_req->phy_out = dma_map_single(dev, &qat_req->out.dh.r,

+	qat_req->phy_out = dma_map_single(dev, &qat_req->out.dh,

 					  sizeof(struct qat_dh_output_params),

 					  DMA_TO_DEVICE);

 	if (unlikely(dma_mapping_error(dev, qat_req->phy_out)))

@@ -729,13 +729,13 @@ static int qat_rsa_enc(struct akcipher_request *req)

 	qat_req->in.rsa.in_tab[3] = 0;

 	qat_req->out.rsa.out_tab[1] = 0;

-	qat_req->phy_in = dma_map_single(dev, &qat_req->in.rsa.enc.m,

+	qat_req->phy_in = dma_map_single(dev, &qat_req->in.rsa,

 					 sizeof(struct qat_rsa_input_params),

 					 DMA_TO_DEVICE);

 	if (unlikely(dma_mapping_error(dev, qat_req->phy_in)))

 		goto unmap_dst;

-	qat_req->phy_out = dma_map_single(dev, &qat_req->out.rsa.enc.c,

+	qat_req->phy_out = dma_map_single(dev, &qat_req->out.rsa,

 					  sizeof(struct qat_rsa_output_params),

 					  DMA_TO_DEVICE);

 	if (unlikely(dma_mapping_error(dev, qat_req->phy_out)))

@@ -875,13 +875,13 @@ static int qat_rsa_dec(struct akcipher_request *req)

 	else

 		qat_req->in.rsa.in_tab[3] = 0;

 	qat_req->out.rsa.out_tab[1] = 0;

-	qat_req->phy_in = dma_map_single(dev, &qat_req->in.rsa.dec.c,

+	qat_req->phy_in = dma_map_single(dev, &qat_req->in.rsa,

 					 sizeof(struct qat_rsa_input_params),

 					 DMA_TO_DEVICE);

 	if (unlikely(dma_mapping_error(dev, qat_req->phy_in)))

 		goto unmap_dst;

-	qat_req->phy_out = dma_map_single(dev, &qat_req->out.rsa.dec.m,

+	qat_req->phy_out = dma_map_single(dev, &qat_req->out.rsa,

 					  sizeof(struct qat_rsa_output_params),

 					  DMA_TO_DEVICE);

 	if (unlikely(dma_mapping_error(dev, qat_req->phy_out)))

-- 

2.35.3